From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942522AbdEYPvF (ORCPT ); Thu, 25 May 2017 11:51:05 -0400 Received: from foss.arm.com ([217.140.101.70]:51452 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S942477AbdEYPuk (ORCPT ); Thu, 25 May 2017 11:50:40 -0400 Date: Thu, 25 May 2017 16:50:42 +0100 From: Will Deacon To: Wei Huang Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com Subject: Re: [PATCH 1/1] drivers/perf: arm_pmu_acpi: avoid perf IRQ init when guest PMU is off Message-ID: <20170525155042.GS2859@arm.com> References: <1495636601-14726-1-git-send-email-wei@redhat.com> <20170525152814.GR2859@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 25, 2017 at 10:49:49AM -0500, Wei Huang wrote: > On 05/25/2017 10:28 AM, Will Deacon wrote: > > On Wed, May 24, 2017 at 09:36:41AM -0500, Wei Huang wrote: > >> if (gicc->flags & ACPI_MADT_PERFORMANCE_IRQ_MODE) > >> trigger = ACPI_EDGE_SENSITIVE; > >> else > >> @@ -58,7 +61,8 @@ static void arm_pmu_acpi_unregister_irq(int cpu) > >> return; > >> > >> gsi = gicc->performance_interrupt; > >> - acpi_unregister_gsi(gsi); > >> + if (gsi) > >> + acpi_unregister_gsi(gsi); > > > > ... but then I don't see how we can get here, so I'll drop this hunk. > > I am OK to drop it. It was added just to be cautious... Do you need > another version from me or you will remove this hunk? I can drop this hunk, no need to repost. Thanks, Will