From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942662AbdEYQqR (ORCPT ); Thu, 25 May 2017 12:46:17 -0400 Received: from mail-it0-f46.google.com ([209.85.214.46]:36042 "EHLO mail-it0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S942640AbdEYQqP (ORCPT ); Thu, 25 May 2017 12:46:15 -0400 Date: Thu, 25 May 2017 10:46:11 -0600 From: Mathieu Poirier To: Thomas Gleixner Cc: LKML , Peter Zijlstra , Ingo Molnar , Steven Rostedt , Sebastian Siewior , Paul McKenney , linux-arm-kernel@lists.infradead.org Subject: Re: [patch V3 11/32] hwtracing/coresight-etm3x: Use cpuhp_setup_state_nocalls_cpuslocked() Message-ID: <20170525164611.GA31052@xps15> References: <20170524081511.203800767@linutronix.de> <20170524081547.889092478@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170524081547.889092478@linutronix.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2017 at 10:15:22AM +0200, Thomas Gleixner wrote: > From: Sebastian Andrzej Siewior > > etm_probe() holds get_online_cpus() while invoking > cpuhp_setup_state_nocalls(). > > cpuhp_setup_state_nocalls() invokes get_online_cpus() as well. This is > correct, but prevents the conversion of the hotplug locking to a percpu > rwsem. > > Use cpuhp_setup_state_nocalls_cpuslocked() to avoid the nested > call. Convert *_online_cpus() to the new interfaces while at it. > > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Cc: Mathieu Poirier > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: linux-arm-kernel@lists.infradead.org Acked-by: Mathieu Poirier > > --- > drivers/hwtracing/coresight/coresight-etm3x.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > --- a/drivers/hwtracing/coresight/coresight-etm3x.c > +++ b/drivers/hwtracing/coresight/coresight-etm3x.c > @@ -587,7 +587,7 @@ static void etm_disable_sysfs(struct cor > * after cpu online mask indicates the cpu is offline but before the > * DYING hotplug callback is serviced by the ETM driver. > */ > - get_online_cpus(); > + cpus_read_lock(); > spin_lock(&drvdata->spinlock); > > /* > @@ -597,7 +597,7 @@ static void etm_disable_sysfs(struct cor > smp_call_function_single(drvdata->cpu, etm_disable_hw, drvdata, 1); > > spin_unlock(&drvdata->spinlock); > - put_online_cpus(); > + cpus_read_unlock(); > > dev_info(drvdata->dev, "ETM tracing disabled\n"); > } > @@ -795,7 +795,7 @@ static int etm_probe(struct amba_device > > drvdata->cpu = pdata ? pdata->cpu : 0; > > - get_online_cpus(); > + cpus_read_lock(); > etmdrvdata[drvdata->cpu] = drvdata; > > if (smp_call_function_single(drvdata->cpu, > @@ -803,17 +803,17 @@ static int etm_probe(struct amba_device > dev_err(dev, "ETM arch init failed\n"); > > if (!etm_count++) { > - cpuhp_setup_state_nocalls(CPUHP_AP_ARM_CORESIGHT_STARTING, > - "arm/coresight:starting", > - etm_starting_cpu, etm_dying_cpu); > - ret = cpuhp_setup_state_nocalls(CPUHP_AP_ONLINE_DYN, > - "arm/coresight:online", > - etm_online_cpu, NULL); > + cpuhp_setup_state_nocalls_cpuslocked(CPUHP_AP_ARM_CORESIGHT_STARTING, > + "arm/coresight:starting", > + etm_starting_cpu, etm_dying_cpu); > + ret = cpuhp_setup_state_nocalls_cpuslocked(CPUHP_AP_ONLINE_DYN, > + "arm/coresight:online", > + etm_online_cpu, NULL); > if (ret < 0) > goto err_arch_supported; > hp_online = ret; > } > - put_online_cpus(); > + cpus_read_unlock(); > > if (etm_arch_supported(drvdata->arch) == false) { > ret = -EINVAL; > >