public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ranjit W <programlinuxstuff@gmail.com>
Cc: sergio.paracuellos@gmail.com, johannes.berg@intel.com,
	luciano.coelho@intel.com, juliana.orod@gmail.com,
	karniksayli1995@gmail.com, avraham.stern@intel.com,
	claudiu.beznea@gmail.com, davem@davemloft.net,
	edumazet@google.com, tklauser@distanz.ch, jarod@redhat.com,
	igor.pylypiv@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging-next: wlan-ng: resolve checkpatch issues
Date: Thu, 25 May 2017 18:55:03 +0200	[thread overview]
Message-ID: <20170525165503.GA14494@kroah.com> (raw)
In-Reply-To: <20170520193346.GA17297@jarvis-beta>

On Sun, May 21, 2017 at 01:03:55AM +0530, Ranjit W wrote:
> fixing following checkpatch warning wherever possible:
> WARNING: line over 80 characters
> 
> Signed-off-by: Ranjit W <programlinuxstuff@gmail.com>
> ---
>  drivers/staging/wlan-ng/cfg80211.c     | 11 ++++++++---
>  drivers/staging/wlan-ng/hfa384x.h      | 21 ++++++++++++++-------
>  drivers/staging/wlan-ng/p80211netdev.c |  3 ++-
>  3 files changed, 24 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index 178f6f5d4613..8915c9240d1c 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -163,7 +163,8 @@ static int prism2_add_key(struct wiphy *wiphy, struct net_device *dev,
> 			goto exit;
> 
> 		/* send key to driver */
> -		did = DIDmib_dot11smt_dot11WEPDefaultKeysTable_key(key_index + 1);
> +		did = DIDmib_dot11smt_dot11WEPDefaultKeysTable_key(key_index
> +									+ 1);

Ick, that looks horrible now, don't you think?  checkpatch is a guide,
not a rule-that-must-always-be-followed.

There are other ways to fix this up, look at that horrible function name
for one such way to resolve it.

thanks,

greg k-h

      reply	other threads:[~2017-05-25 16:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-20 19:33 [PATCH] staging-next: wlan-ng: resolve checkpatch issues Ranjit W
2017-05-25 16:55 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170525165503.GA14494@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=avraham.stern@intel.com \
    --cc=claudiu.beznea@gmail.com \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=edumazet@google.com \
    --cc=igor.pylypiv@gmail.com \
    --cc=jarod@redhat.com \
    --cc=johannes.berg@intel.com \
    --cc=juliana.orod@gmail.com \
    --cc=karniksayli1995@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luciano.coelho@intel.com \
    --cc=programlinuxstuff@gmail.com \
    --cc=sergio.paracuellos@gmail.com \
    --cc=tklauser@distanz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox