From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942662AbdEYQ4S (ORCPT ); Thu, 25 May 2017 12:56:18 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38104 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933120AbdEYQ4Q (ORCPT ); Thu, 25 May 2017 12:56:16 -0400 Date: Thu, 25 May 2017 18:55:03 +0200 From: Greg KH To: Ranjit W Cc: sergio.paracuellos@gmail.com, johannes.berg@intel.com, luciano.coelho@intel.com, juliana.orod@gmail.com, karniksayli1995@gmail.com, avraham.stern@intel.com, claudiu.beznea@gmail.com, davem@davemloft.net, edumazet@google.com, tklauser@distanz.ch, jarod@redhat.com, igor.pylypiv@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging-next: wlan-ng: resolve checkpatch issues Message-ID: <20170525165503.GA14494@kroah.com> References: <20170520193346.GA17297@jarvis-beta> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170520193346.GA17297@jarvis-beta> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 21, 2017 at 01:03:55AM +0530, Ranjit W wrote: > fixing following checkpatch warning wherever possible: > WARNING: line over 80 characters > > Signed-off-by: Ranjit W > --- > drivers/staging/wlan-ng/cfg80211.c | 11 ++++++++--- > drivers/staging/wlan-ng/hfa384x.h | 21 ++++++++++++++------- > drivers/staging/wlan-ng/p80211netdev.c | 3 ++- > 3 files changed, 24 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c > index 178f6f5d4613..8915c9240d1c 100644 > --- a/drivers/staging/wlan-ng/cfg80211.c > +++ b/drivers/staging/wlan-ng/cfg80211.c > @@ -163,7 +163,8 @@ static int prism2_add_key(struct wiphy *wiphy, struct net_device *dev, > goto exit; > > /* send key to driver */ > - did = DIDmib_dot11smt_dot11WEPDefaultKeysTable_key(key_index + 1); > + did = DIDmib_dot11smt_dot11WEPDefaultKeysTable_key(key_index > + + 1); Ick, that looks horrible now, don't you think? checkpatch is a guide, not a rule-that-must-always-be-followed. There are other ways to fix this up, look at that horrible function name for one such way to resolve it. thanks, greg k-h