public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue
@ 2017-05-18 10:07 srishti
  2017-05-18 10:13 ` Dan Carpenter
  0 siblings, 1 reply; 11+ messages in thread
From: srishti @ 2017-05-18 10:07 UTC (permalink / raw)
  To: gregkh
  Cc: swarren, lee, eric, f.fainelli, rjui, sbranden,
	bcm-kernel-feedback-list, dan.carpenter, vicmos89, srishtishar,
	mzoran, devel, linux-rpi-kernel, linux-arm-kernel, linux-kernel

Fixed a trailing */ issue.

Signed-off-by: srishti <srishtishar@gmail.com>
---
 drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
index a4ffa1b..38fabab 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-ctl.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
@@ -247,8 +247,8 @@ static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol *kcontrol,
 	struct snd_ctl_elem_value *ucontrol)
 {
 	/* bcm2835 supports only consumer mode and sets all other format flags
-	 * automatically. So the only thing left is signalling non-audio
-	 * content */
+	 * automatically. So the only thing left is signalling non-audio content
+	 */
 	ucontrol->value.iec958.status[0] = IEC958_AES0_NONAUDIO;
 	return 0;
 }
2.7.4

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue
  2017-05-18 10:07 srishti
@ 2017-05-18 10:13 ` Dan Carpenter
  0 siblings, 0 replies; 11+ messages in thread
From: Dan Carpenter @ 2017-05-18 10:13 UTC (permalink / raw)
  To: srishti
  Cc: gregkh, devel, f.fainelli, sbranden, swarren, rjui, lee, vicmos89,
	linux-kernel, eric, bcm-kernel-feedback-list, linux-rpi-kernel,
	mzoran, linux-arm-kernel

On Thu, May 18, 2017 at 03:37:48PM +0530, srishti wrote:
> Fixed a trailing */ issue.
> 
> Signed-off-by: srishti <srishtishar@gmail.com>

Fix your From header and your signed-off-by line to use your legal name
as if you were signing a legal document.

regards,
dan carpenter

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue
@ 2017-05-18 10:42 srishti
  0 siblings, 0 replies; 11+ messages in thread
From: srishti @ 2017-05-18 10:42 UTC (permalink / raw)
  To: gregkh
  Cc: swarren, lee, eric, f.fainelli, rjui, sbranden,
	bcm-kernel-feedback-list, dan.carpenter, vicmos89, srishtishar,
	mzoran, devel, linux-rpi-kernel, linux-arm-kernel, linux-kernel

From: srishti sharma <srishtishar@gmail.com>

Fixed a trailing */ issue.

Signed-off-by: srishti sharma <srishtishar@gmail.com>
---
 drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
index a4ffa1b..38fabab 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-ctl.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
@@ -247,8 +247,8 @@ static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol *kcontrol,
 	struct snd_ctl_elem_value *ucontrol)
 {
 	/* bcm2835 supports only consumer mode and sets all other format flags
-	 * automatically. So the only thing left is signalling non-audio
-	 * content */
+	 * automatically. So the only thing left is signalling non-audio content
+	 */
 	ucontrol->value.iec958.status[0] = IEC958_AES0_NONAUDIO;
 	return 0;
 }
2.7.4

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue
@ 2017-05-18 10:50 srishti
  2017-05-18 13:58 ` Greg KH
  0 siblings, 1 reply; 11+ messages in thread
From: srishti @ 2017-05-18 10:50 UTC (permalink / raw)
  To: gregkh
  Cc: swarren, lee, eric, f.fainelli, rjui, sbranden,
	bcm-kernel-feedback-list, dan.carpenter, vicmos89, srishtishar,
	mzoran, devel, linux-rpi-kernel, linux-arm-kernel, linux-kernel

From: srishti sharma <srishtishar@gmail.com>

Fixed a trailing */ issue.

Signed-off-by: srishti sharma <srishtishar@gmail.com>
---
 drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
index a4ffa1b..38fabab 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-ctl.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
@@ -247,8 +247,8 @@ static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol *kcontrol,
 	struct snd_ctl_elem_value *ucontrol)
 {
 	/* bcm2835 supports only consumer mode and sets all other format flags
-	 * automatically. So the only thing left is signalling non-audio
-	 * content */
+	 * automatically. So the only thing left is signalling non-audio content
+	 */
 	ucontrol->value.iec958.status[0] = IEC958_AES0_NONAUDIO;
 	return 0;
 }
2.7.4

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue
  2017-05-18 10:50 srishti
@ 2017-05-18 13:58 ` Greg KH
  2017-05-19 19:30   ` srishti sharma
  0 siblings, 1 reply; 11+ messages in thread
From: Greg KH @ 2017-05-18 13:58 UTC (permalink / raw)
  To: srishti
  Cc: devel, f.fainelli, sbranden, swarren, rjui, lee, vicmos89,
	linux-kernel, eric, bcm-kernel-feedback-list, linux-rpi-kernel,
	mzoran, dan.carpenter, linux-arm-kernel

On Thu, May 18, 2017 at 04:20:15PM +0530, srishti wrote:
> From: srishti sharma <srishtishar@gmail.com>
> 
> Fixed a trailing */ issue.
> 
> Signed-off-by: srishti sharma <srishtishar@gmail.com>
> ---
>  drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

You sent two copies of this, which am I supposed to apply?  And what
changed from the last version?

I'm dropping this, please fix and only send _one_ copy of the patch.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue
  2017-05-18 13:58 ` Greg KH
@ 2017-05-19 19:30   ` srishti sharma
  2017-05-19 19:33     ` Dan Carpenter
  0 siblings, 1 reply; 11+ messages in thread
From: srishti sharma @ 2017-05-19 19:30 UTC (permalink / raw)
  To: Greg KH
  Cc: devel, Florian Fainelli, sbranden, Stephen Warren, rjui, lee,
	Victor Vaschenko, linux-kernel, Eric Anholt,
	bcm-kernel-feedback-list, linux-rpi-kernel, mzoran, dan.carpenter,
	linux-arm-kernel

Was the format of this patch acceptable ,the "from" matches the
"signed-off-by" right , so this should be correct , were there any
errors in this ? Should I resend it ?

Regards,
Srishti

On Thu, May 18, 2017 at 7:28 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, May 18, 2017 at 04:20:15PM +0530, srishti wrote:
>> From: srishti sharma <srishtishar@gmail.com>
>>
>> Fixed a trailing */ issue.
>>
>> Signed-off-by: srishti sharma <srishtishar@gmail.com>
>> ---
>>  drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> You sent two copies of this, which am I supposed to apply?  And what
> changed from the last version?
>
> I'm dropping this, please fix and only send _one_ copy of the patch.
>
> thanks,
>
> greg k-h

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue
  2017-05-19 19:30   ` srishti sharma
@ 2017-05-19 19:33     ` Dan Carpenter
  2017-05-19 19:56       ` srishti sharma
  0 siblings, 1 reply; 11+ messages in thread
From: Dan Carpenter @ 2017-05-19 19:33 UTC (permalink / raw)
  To: srishti sharma
  Cc: Greg KH, devel, Florian Fainelli, sbranden, Stephen Warren, rjui,
	lee, Victor Vaschenko, linux-kernel, Eric Anholt,
	bcm-kernel-feedback-list, linux-rpi-kernel, mzoran,
	linux-arm-kernel

On Sat, May 20, 2017 at 01:00:17AM +0530, srishti sharma wrote:
> Was the format of this patch acceptable ,the "from" matches the
> "signed-off-by" right , so this should be correct , were there any
> errors in this ? Should I resend it ?
> 
> Regards,
> Srishti
> 

You should capitalize your name in both since you're doing that here.

Also I really think you can figure out how to fix your email headers so
you don't need to use a From header.  Lots of people use gmail and they
were able to figure it out.

But yeah, the way you sent it is also fine.

regards,
dan carpenter

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue
  2017-05-19 19:33     ` Dan Carpenter
@ 2017-05-19 19:56       ` srishti sharma
  0 siblings, 0 replies; 11+ messages in thread
From: srishti sharma @ 2017-05-19 19:56 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Greg KH, devel, Florian Fainelli, sbranden, Stephen Warren, rjui,
	lee, Victor Vaschenko, linux-kernel, Eric Anholt,
	bcm-kernel-feedback-list, linux-rpi-kernel, mzoran,
	linux-arm-kernel

On Sat, May 20, 2017 at 1:03 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Sat, May 20, 2017 at 01:00:17AM +0530, srishti sharma wrote:
>> Was the format of this patch acceptable ,the "from" matches the
>> "signed-off-by" right , so this should be correct , were there any
>> errors in this ? Should I resend it ?
>>
>> Regards,
>> Srishti
>>
>
> You should capitalize your name in both since you're doing that here.
>
> Also I really think you can figure out how to fix your email headers so
> you don't need to use a From header.  Lots of people use gmail and they
> were able to figure it out.
>
> But yeah, the way you sent it is also fine.
>
> regards,
> dan carpenter
>


Okay , Thanks a lot !

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue.
@ 2017-05-19 20:30 srishti sharma
  2017-05-25 16:57 ` Greg KH
  0 siblings, 1 reply; 11+ messages in thread
From: srishti sharma @ 2017-05-19 20:30 UTC (permalink / raw)
  To: gregkh
  Cc: swarren, lee, eric, f.fainelli, rjui, sbranden,
	bcm-kernel-feedback-list, dan.carpenter, vicmos89, srishtishar,
	mzoran, devel, linux-rpi-kernel, linux-arm-kernel, linux-kernel

fixed a trailing */ issue .

Signed-off-by: srishti sharma <srishtishar@gmail.com>
---
 drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
index a4ffa1b..38fabab 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-ctl.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
@@ -247,8 +247,8 @@ static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol *kcontrol,
 	struct snd_ctl_elem_value *ucontrol)
 {
 	/* bcm2835 supports only consumer mode and sets all other format flags
-	 * automatically. So the only thing left is signalling non-audio
-	 * content */
+	 * automatically. So the only thing left is signalling non-audio content
+	 */
 	ucontrol->value.iec958.status[0] = IEC958_AES0_NONAUDIO;
 	return 0;
 }
2.7.4

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue.
  2017-05-19 20:30 [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue srishti sharma
@ 2017-05-25 16:57 ` Greg KH
  2017-05-25 19:27   ` srishti sharma
  0 siblings, 1 reply; 11+ messages in thread
From: Greg KH @ 2017-05-25 16:57 UTC (permalink / raw)
  To: srishti sharma
  Cc: devel, f.fainelli, sbranden, swarren, rjui, lee, vicmos89,
	linux-kernel, eric, bcm-kernel-feedback-list, linux-rpi-kernel,
	mzoran, dan.carpenter, linux-arm-kernel

On Sat, May 20, 2017 at 02:00:24AM +0530, srishti sharma wrote:
> fixed a trailing */ issue .
> 
> Signed-off-by: srishti sharma <srishtishar@gmail.com>
> ---
>  drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This file isn't in my tree, always work against linux-next please...

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue.
  2017-05-25 16:57 ` Greg KH
@ 2017-05-25 19:27   ` srishti sharma
  0 siblings, 0 replies; 11+ messages in thread
From: srishti sharma @ 2017-05-25 19:27 UTC (permalink / raw)
  To: Greg KH
  Cc: devel, Florian Fainelli, sbranden, Stephen Warren, rjui, lee,
	Victor Vaschenko, linux-kernel, Eric Anholt,
	bcm-kernel-feedback-list, linux-rpi-kernel, mzoran, Dan Carpenter,
	linux-arm-kernel

On Thu, May 25, 2017 at 10:27 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sat, May 20, 2017 at 02:00:24AM +0530, srishti sharma wrote:
>> fixed a trailing */ issue .
>>
>> Signed-off-by: srishti sharma <srishtishar@gmail.com>
>> ---
>>  drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> This file isn't in my tree, always work against linux-next please...
>
> thanks,
>
> greg k-h


Thanks for letting me know !

Regards,
Srishti

^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-05-25 19:27 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-19 20:30 [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue srishti sharma
2017-05-25 16:57 ` Greg KH
2017-05-25 19:27   ` srishti sharma
  -- strict thread matches above, loose matches on Subject: below --
2017-05-18 10:50 srishti
2017-05-18 13:58 ` Greg KH
2017-05-19 19:30   ` srishti sharma
2017-05-19 19:33     ` Dan Carpenter
2017-05-19 19:56       ` srishti sharma
2017-05-18 10:42 srishti
2017-05-18 10:07 srishti
2017-05-18 10:13 ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox