From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942919AbdEYRBD (ORCPT ); Thu, 25 May 2017 13:01:03 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:44686 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S942800AbdEYRA6 (ORCPT ); Thu, 25 May 2017 13:00:58 -0400 Date: Thu, 25 May 2017 19:00:51 +0200 From: Andrew Lunn To: Shubham Bansal Cc: Russell King - ARM Linux , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] RFC: arm: eBPF JIT compiler Message-ID: <20170525170051.GC18357@lunn.ch> References: <1495564433-9750-1-git-send-email-illusionist.neo@gmail.com> <20170523204608.GG24807@lunn.ch> <20170523232555.GY13759@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 25, 2017 at 02:01:36AM +0530, Shubham Bansal wrote: > Hi Andrew, > > I am attaching the latest patch which should work on ARMv5 , ARMv6 and ARMv7. > > Please test on your machines. Apologies for the last patch. This patch > should work though. andrew@shuttle:~/linux$ make -s -j 16 arch/arm/net/bpf_jit_32.c:1755:12: warning: ‘validate_code’ defined but not used [-Wunused-function] static int validate_code(struct jit_ctx *ctx) ^~~~~~~~~~~~~ arch/arm/net/bpf_jit_32.c:1724:12: warning: ‘build_body’ defined but not used [-Wunused-function] static int build_body(struct jit_ctx *ctx) ^~~~~~~~~~ arch/arm/net/bpf_jit_32.c:1122:13: warning: ‘build_epilogue’ defined but not used [-Wunused-function] static void build_epilogue(struct jit_ctx *ctx) ^~~~~~~~~~~~~~ arch/arm/net/bpf_jit_32.c:1049:13: warning: ‘build_prologue’ defined but not used [-Wunused-function] static void build_prologue(struct jit_ctx *ctx) ^~~~~~~~~~~~~~ arch/arm/net/bpf_jit_32.c:174:13: warning: ‘jit_fill_hole’ defined but not used [-Wunused-function] static void jit_fill_hole(void *area, unsigned int size) ^~~~~~~~~~~~~ I _think_ this is because CONFIG_CPU_LITTLE_ENDIAN is not set. But it is a little endian machine/configuration. ARM does not seem to use CONFIG_CPU_LITTLE_ENDIAN, it just has CPU_BIG_ENDIAN. Andrew