From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938984AbdEYUzP (ORCPT ); Thu, 25 May 2017 16:55:15 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:36961 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936462AbdEYUzA (ORCPT ); Thu, 25 May 2017 16:55:00 -0400 Date: Thu, 25 May 2017 22:54:55 +0200 From: Daniel Lezcano To: Dong Aisheng Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, shawnguo@kernel.org, ping.bai@nxp.com, anson.huang@nxp.com, dongas86@gmail.com, kernel@pengutronix.de, arnd@arndb.de Subject: Re: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support Message-ID: <20170525205455.GB9501@mai> References: <1494660575-30465-1-git-send-email-aisheng.dong@nxp.com> <1494660575-30465-2-git-send-email-aisheng.dong@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494660575-30465-2-git-send-email-aisheng.dong@nxp.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 13, 2017 at 03:29:35PM +0800, Dong Aisheng wrote: > IMX Timer/PWM Module (TPM) supports both timer and pwm function while > this patch only adds the timer support. PWM would be added later. > > The TPM counter, compare and capture registers are clocked by an > asynchronous clock that can remain enabled in low power modes. > > Cc: Daniel Lezcano > Cc: Thomas Gleixner > Cc: Shawn Guo > Signed-off-by: Anson Huang > Signed-off-by: Bai Ping > Signed-off-by: Dong Aisheng > --- [ ... ] > + val = __raw_readl(timer_base + TPM_C0SC); > + val &= ~(TPM_C0SC_MODE_MASK | TPM_C0SC_CHIE); > + __raw_writel(val, timer_base + TPM_C0SC); Hi Dong, why are you using __raw_write/__raw_read instead of regular readl/writel?