From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S944511AbdEZSia (ORCPT ); Fri, 26 May 2017 14:38:30 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44932 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932235AbdEZSiZ (ORCPT ); Fri, 26 May 2017 14:38:25 -0400 Date: Fri, 26 May 2017 20:38:14 +0200 From: Greg Kroah-Hartman To: Jan Kiszka Cc: Linus Walleij , Alexandre Courbot , Linux Kernel Mailing List , linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org, Sudip Mukherjee , Andy Shevchenko , Sascha Weisenberger Subject: Re: [PATCH 1/8] serial: exar: Preconfigure xr17v35x MPIOs as output Message-ID: <20170526183814.GD16490@kroah.com> References: <6155891d19531be018d30fd55ffd6d42493af8c1.1494660546.git.jan.kiszka@siemens.com> <9bb8d972-6535-1611-8fa7-f5fe89760531@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9bb8d972-6535-1611-8fa7-f5fe89760531@siemens.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 26, 2017 at 03:04:26PM +0200, Jan Kiszka wrote: > Greg, > > On 2017-05-13 09:28, Jan Kiszka wrote: > > This is the safe default for GPIOs with unknown external wiring. > > > > Signed-off-by: Jan Kiszka > > --- > > drivers/tty/serial/8250/8250_exar.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c > > index 1270ff163f63..b4fa585156c7 100644 > > --- a/drivers/tty/serial/8250/8250_exar.c > > +++ b/drivers/tty/serial/8250/8250_exar.c > > @@ -177,13 +177,13 @@ static void setup_gpio(u8 __iomem *p) > > writeb(0x00, p + UART_EXAR_MPIOLVL_7_0); > > writeb(0x00, p + UART_EXAR_MPIO3T_7_0); > > writeb(0x00, p + UART_EXAR_MPIOINV_7_0); > > - writeb(0x00, p + UART_EXAR_MPIOSEL_7_0); > > + writeb(0xff, p + UART_EXAR_MPIOSEL_7_0); > > writeb(0x00, p + UART_EXAR_MPIOOD_7_0); > > writeb(0x00, p + UART_EXAR_MPIOINT_15_8); > > writeb(0x00, p + UART_EXAR_MPIOLVL_15_8); > > writeb(0x00, p + UART_EXAR_MPIO3T_15_8); > > writeb(0x00, p + UART_EXAR_MPIOINV_15_8); > > - writeb(0x00, p + UART_EXAR_MPIOSEL_15_8); > > + writeb(0xff, p + UART_EXAR_MPIOSEL_15_8); > > writeb(0x00, p + UART_EXAR_MPIOOD_15_8); > > } > > > > > > Please drop from this tty-next, it may break Commtech adapters. I have > an update ready. > > I may also send a fix on top if that is preferred, just let me know. I need a fixup patch, I can't drop a patch, only revert it. thanks, greg k-h