From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033062AbdE0Brt (ORCPT ); Fri, 26 May 2017 21:47:49 -0400 Received: from mail-pg0-f48.google.com ([74.125.83.48]:32970 "EHLO mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937451AbdE0BMM (ORCPT ); Fri, 26 May 2017 21:12:12 -0400 Date: Fri, 26 May 2017 18:12:08 -0700 From: Bjorn Andersson To: Sarangdhar Joshi Cc: Ohad Ben-Cohen , Loic Pallardy , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Stephen Boyd , Trilok Soni Subject: Re: [PATCH v3 1/2] remoteproc: Introduce rproc_{start,stop}() functions Message-ID: <20170527011208.GA1730@builder> References: <1495842661-8926-1-git-send-email-spjoshi@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495842661-8926-1-git-send-email-spjoshi@codeaurora.org> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 26 May 16:51 PDT 2017, Sarangdhar Joshi wrote: > In the context of recovering from crash, rproc_trigger_recovery() does > rproc_shutdown() followed by rproc_boot(). The remoteproc resources are > cleaned up in rproc_shutdown() and immediately reallocated in > rproc_boot() which is an unnecessary overhead. Furthermore, we want the > memory regions to be accessible after stopping the remote processor, to > be able to extract the memory content for a coredump. > > This patch factors out the code in rproc_boot() and rproc_shutdown() > path and introduces rproc_{start,stop}() in order to avoid resource > allocation overhead. > > Signed-off-by: Sarangdhar Joshi Both patches applied. Thanks, Bjorn