From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755893AbdE0Kvs (ORCPT ); Sat, 27 May 2017 06:51:48 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36656 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751968AbdE0Kvk (ORCPT ); Sat, 27 May 2017 06:51:40 -0400 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Darren Hart Subject: Re: [PATCH] platform/x86: dell-wmi: Add a comment explaining the 0xb2 magic number Date: Sat, 27 May 2017 12:51:36 +0200 User-Agent: KMail/1.13.7 (Linux/3.13.0-117-generic; KDE/4.14.2; x86_64; ; ) Cc: platform-driver-x86@vger.kernel.org, LKML , Andy Lutomirski , Matthew Garrett , Andy Shevchenko References: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1837375.UKsI5RX0LM"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201705271251.37069@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart1837375.UKsI5RX0LM Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Saturday 27 May 2017 07:15:28 Darren Hart wrote: > From: Andy Lutomirski >=20 > The hotkey table is 0xb2, add a comment for clarity. >=20 > Suggested-by: Darren Hart > Signed-off-by: Andy Lutomirski > Cc: Matthew Garrett > Cc: "Pali Roh=C3=A1r" > Cc: Andy Shevchenko > Signed-off-by: Darren Hart (VMware) > --- > drivers/platform/x86/dell-wmi.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/platform/x86/dell-wmi.c > b/drivers/platform/x86/dell-wmi.c index 8a64c79..24467b1 100644 > --- a/drivers/platform/x86/dell-wmi.c > +++ b/drivers/platform/x86/dell-wmi.c > @@ -449,6 +449,7 @@ static void __init handle_dmi_entry(const struct > dmi_header *dm, if (results->err || results->keymap) > return; /* We already found the hotkey table. */ >=20 > + /* The Dell hotkey table is type 0xB2. Scan until we find it. */ > if (dm->type !=3D 0xb2) > return; Good. Reviewed-by: Pali Roh=C3=A1r (Maybe in future we should add a #define name for such magic constants) =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart1837375.UKsI5RX0LM Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlkpWjkACgkQi/DJPQPkQ1IodwCgvFj4FuuHqq8qx9B6mp6CywH1 CRQAoLYpy8EMWnW+9oasTfRitTnZA0kW =VBRk -----END PGP SIGNATURE----- --nextPart1837375.UKsI5RX0LM--