From: Christoph Hellwig <hch@infradead.org>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, Cliff Whickman <cpw@sgi.com>,
Robin Holt <robinmholt@gmail.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v4] sgi-xp: Use designated initializers
Date: Sat, 27 May 2017 21:59:59 -0700 [thread overview]
Message-ID: <20170528045958.GC5045@infradead.org> (raw)
In-Reply-To: <20170528003914.GA134657@beast>
On Sat, May 27, 2017 at 05:39:14PM -0700, Kees Cook wrote:
> Prepare to mark sensitive kernel structures for randomization by making
> sure they're using designated initializers. In this case, no initializers
> are needed (they can be NULL initialized and callers adjusted to check
> for NULL, which is more efficient than an indirect call).
I'd say this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Until I noticed all this is unused, so we should just remove it
entirely. I now remember the weird SGI excuse, but given that they
haven't managed to get their code upstream in more than 10 years there
is no valid reason at all to keep this around.
prev parent reply other threads:[~2017-05-28 5:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-28 0:39 [PATCH v4] sgi-xp: Use designated initializers Kees Cook
2017-05-28 4:59 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170528045958.GC5045@infradead.org \
--to=hch@infradead.org \
--cc=cpw@sgi.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robinmholt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).