From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750865AbdE1FAB (ORCPT ); Sun, 28 May 2017 01:00:01 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:55817 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbdE1FAA (ORCPT ); Sun, 28 May 2017 01:00:00 -0400 Date: Sat, 27 May 2017 21:59:59 -0700 From: Christoph Hellwig To: Kees Cook Cc: linux-kernel@vger.kernel.org, Cliff Whickman , Robin Holt , Christoph Hellwig Subject: Re: [PATCH v4] sgi-xp: Use designated initializers Message-ID: <20170528045958.GC5045@infradead.org> References: <20170528003914.GA134657@beast> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170528003914.GA134657@beast> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 27, 2017 at 05:39:14PM -0700, Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. In this case, no initializers > are needed (they can be NULL initialized and callers adjusted to check > for NULL, which is more efficient than an indirect call). I'd say this looks good: Reviewed-by: Christoph Hellwig Until I noticed all this is unused, so we should just remove it entirely. I now remember the weird SGI excuse, but given that they haven't managed to get their code upstream in more than 10 years there is no valid reason at all to keep this around.