From: Christoph Hellwig <hch@infradead.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH 1/3] cfq-iosched: Mark cfq_clear_cfqq_*() as __maybe_unused
Date: Sun, 28 May 2017 00:49:52 -0700 [thread overview]
Message-ID: <20170528074952.GA22193@infradead.org> (raw)
In-Reply-To: <20170526212237.103525-2-mka@chromium.org>
On Fri, May 26, 2017 at 02:22:35PM -0700, Matthias Kaehlcke wrote:
> This fixes the following warning when building with clang:
>
> block/cfq-iosched.c:449:1: error: unused function 'cfq_clear_cfqq_sync'
> [-Werror,-Wunused-function]
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Matthias, can you please stop sending these patches? Gcc semantics
correctly are that static inlines can be unused and it's perfectly
fine. It's your job to make clang fit that instead of spreading garbage
all over the kernel.
next prev parent reply other threads:[~2017-05-28 7:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 21:22 [PATCH 0/3] cfq-iosched: Fix warnings about unused functions Matthias Kaehlcke
2017-05-26 21:22 ` [PATCH 1/3] cfq-iosched: Mark cfq_clear_cfqq_*() as __maybe_unused Matthias Kaehlcke
2017-05-28 7:49 ` Christoph Hellwig [this message]
2017-05-30 16:28 ` Doug Anderson
2017-05-26 21:22 ` [PATCH 2/3] cfq-iosched: Fix warning about unused dummy functions Matthias Kaehlcke
2017-05-26 21:22 ` [PATCH 3/3] cfq-iosched: Delete unused function min_vdisktime() Matthias Kaehlcke
2017-05-30 15:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170528074952.GA22193@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dianders@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).