From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750951AbdE1Htz (ORCPT ); Sun, 28 May 2017 03:49:55 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:48900 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750820AbdE1Hty (ORCPT ); Sun, 28 May 2017 03:49:54 -0400 Date: Sun, 28 May 2017 00:49:52 -0700 From: Christoph Hellwig To: Matthias Kaehlcke Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Douglas Anderson Subject: Re: [PATCH 1/3] cfq-iosched: Mark cfq_clear_cfqq_*() as __maybe_unused Message-ID: <20170528074952.GA22193@infradead.org> References: <20170526212237.103525-1-mka@chromium.org> <20170526212237.103525-2-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170526212237.103525-2-mka@chromium.org> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 26, 2017 at 02:22:35PM -0700, Matthias Kaehlcke wrote: > This fixes the following warning when building with clang: > > block/cfq-iosched.c:449:1: error: unused function 'cfq_clear_cfqq_sync' > [-Werror,-Wunused-function] > > Signed-off-by: Matthias Kaehlcke Matthias, can you please stop sending these patches? Gcc semantics correctly are that static inlines can be unused and it's perfectly fine. It's your job to make clang fit that instead of spreading garbage all over the kernel.