public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: linux-mtd@lists.infradead.org, andrew@lunn.ch,
	computersforpeace@gmail.com, dwmw2@infradead.org,
	linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Subject: Re: [PATCH v4 2/5] mtd: mchp23k256: switch to mtd_device_register()
Date: Mon, 29 May 2017 11:13:34 +0200	[thread overview]
Message-ID: <20170529111334.00cb8fbe@bbrezillon> (raw)
In-Reply-To: <20170524234916.16181-3-chris.packham@alliedtelesis.co.nz>

On Thu, 25 May 2017 11:49:13 +1200
Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:

> Use mtd_device_register() instead of mtd_device_parse_register() to
> eliminate two unused parameters.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Tested-by: Andrew Lunn <andrew@lunn.ch>

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
> Changes in v2
> - collect review/test from Andrew
> Changes in v3:
> - None
> Changes in v4:
> - None
> 
>  drivers/mtd/devices/mchp23k256.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/devices/mchp23k256.c b/drivers/mtd/devices/mchp23k256.c
> index 9d8306a15833..2542f5b8b63f 100644
> --- a/drivers/mtd/devices/mchp23k256.c
> +++ b/drivers/mtd/devices/mchp23k256.c
> @@ -151,9 +151,8 @@ static int mchp23k256_probe(struct spi_device *spi)
>  	flash->mtd._read	= mchp23k256_read;
>  	flash->mtd._write	= mchp23k256_write;
>  
> -	err = mtd_device_parse_register(&flash->mtd, NULL, NULL,
> -					data ? data->parts : NULL,
> -					data ? data->nr_parts : 0);
> +	err = mtd_device_register(&flash->mtd, data ? data->parts : NULL,
> +				  data ? data->nr_parts : 0);
>  	if (err)
>  		return err;
>  

  reply	other threads:[~2017-05-29  9:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-24 23:49 [PATCH v4 0/5] mtd: mchp23k256: device tree and mchp23lcv1024 Chris Packham
2017-05-24 23:49 ` [PATCH v4 1/5] mtd: mchp23k256: Add OF device ID table Chris Packham
2017-05-29  9:13   ` Boris Brezillon
2017-05-31 17:50   ` Rob Herring
2017-05-24 23:49 ` [PATCH v4 2/5] mtd: mchp23k256: switch to mtd_device_register() Chris Packham
2017-05-29  9:13   ` Boris Brezillon [this message]
2017-05-24 23:49 ` [PATCH v4 3/5] mtd: handle partitioning on devices with 0 erasesize Chris Packham
2017-05-29  9:13   ` Boris Brezillon
2017-05-24 23:49 ` [PATCH v4 4/5] mtd: mchp23k256: add partitioning support Chris Packham
2017-05-29  9:14   ` Boris Brezillon
2017-06-01 18:45   ` Brian Norris
2017-05-24 23:49 ` [PATCH v4 5/5] mtd: mchp23k256: Add support for mchp23lcv1024 Chris Packham
2017-05-29  9:15   ` Boris Brezillon
2017-05-31 17:52   ` Rob Herring
2017-06-01 18:46 ` [PATCH v4 0/5] mtd: mchp23k256: device tree and mchp23lcv1024 Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170529111334.00cb8fbe@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=andrew@lunn.ch \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox