Re: [PATCH v4 2/5] mtd: mchp23k256: switch to mtd_device_register()

Boris Brezillon
2017-05-29T09:14:07Z

On Thu, 25 May 2017 11:49:13 +1200
Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:

> Use mtd_device_register() instead of mtd_device_parse_register() to
> eliminate two unused parameters.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Tested-by: Andrew Lunn <andrew@lunn.ch>

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
> Changes in v2
> - collect review/test from Andrew
> Changes in v3:
> - None
> Changes in v4:
> - None
>
> drivers/mtd/devices/mchp23k256.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/devices/mchp23k256.c b/drivers/mtd/devices/mchp23k256.c
> index 9d8306a15833..2542f5b8b63f 100644
> --- a/drivers/mtd/devices/mchp23k256.c
> +++ b/drivers/mtd/devices/mchp23k256.c
> @@ -151,9 +151,8 @@ static int mchp23k256_probe(struct spi_device *spi)
> flash->mtd._read = mchp23k256_read;
> flash->mtd._write = mchp23k256_write;
>
> - err = mtd_device_parse_register(&flash->mtd, NULL, NULL,
> - data ? data->parts : NULL,
> - data ? data->nr_parts : 0);
> + err = mtd_device_register(&flash->mtd, data ? data->parts : NULL,
> + data ? data->nr_parts : 0);
> if (err)
> return err;
>