From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751120AbdE2Odg (ORCPT ); Mon, 29 May 2017 10:33:36 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53200 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbdE2Odf (ORCPT ); Mon, 29 May 2017 10:33:35 -0400 Date: Mon, 29 May 2017 16:28:44 +0200 From: Greg Kroah-Hartman To: Oleg Drokin Cc: devel@driverdev.osuosl.org, Andreas Dilger , James Simmons , Al Viro , Linux Kernel Mailing List , Lustre Development List , "John L . Hammond" Subject: Re: [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe() Message-ID: <20170529142843.GA11952@kroah.com> References: <20170527034033.223677-1-green@linuxhacker.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170527034033.223677-1-green@linuxhacker.ru> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 26, 2017 at 11:40:33PM -0400, Oleg Drokin wrote: > lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct > lov_user_md pointer from user- or kernel-space. This changes the > behavior of copy_from_user() on SPARC and may result in a misaligned > access exception which in turn oopses the kernel. In fact the > relevant argument to lov_getstripe() is never called with a > kernel-space pointer and so changing the address limits is unnecessary > and so we remove the calls to save, set, and restore the address > limits. > > Signed-off-by: John L. Hammond > Reviewed-on: http://review.whamcloud.com/6150 > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3221 > Reviewed-by: Andreas Dilger > Reviewed-by: Li Wei > Signed-off-by: Oleg Drokin > --- > drivers/staging/lustre/lustre/lov/lov_pack.c | 9 --------- > 1 file changed, 9 deletions(-) So is this the patch that you want applied to the staging tree(s) as well? If so, please let me know, otherwise I have no clue... Come on, you know better than this... greg k-h