From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: linux-crypto@vger.kernel.org, devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, Ofir Drang <ofir.drang@arm.com>
Subject: Re: [PATCH 01/12] staging: ccree: correct coding style violations
Date: Mon, 29 May 2017 16:37:28 +0200 [thread overview]
Message-ID: <20170529143728.GA12428@kroah.com> (raw)
In-Reply-To: <1495982440-10047-2-git-send-email-gilad@benyossef.com>
On Sun, May 28, 2017 at 05:40:26PM +0300, Gilad Ben-Yossef wrote:
> cc_crypto_ctx.h had multiple coding style violations reported by
> checkpatch. Fix them all.
Sorry, no. You need to do only one-thing-per-patch, and "fix all coding
style issues is not "one thing". I wouldn't take this kind of patch
from anyone else, so why should I take it from you? :)
thnaks,
greg k-h
next prev parent reply other threads:[~2017-05-29 14:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-28 14:40 [PATCH 00/12] staging: ccree: addtional driver cleanups Gilad Ben-Yossef
2017-05-28 14:40 ` [PATCH 01/12] staging: ccree: correct coding style violations Gilad Ben-Yossef
2017-05-29 14:37 ` Greg Kroah-Hartman [this message]
2017-05-29 16:57 ` Joe Perches
2017-05-29 17:11 ` Gilad Ben-Yossef
2017-05-29 17:36 ` Joe Perches
2017-05-29 17:51 ` Gilad Ben-Yossef
2017-05-28 14:40 ` [PATCH 02/12] staging: ccree: move to kernel bitfields/bitops Gilad Ben-Yossef
2017-05-29 14:38 ` Greg Kroah-Hartman
2017-05-29 17:23 ` Gilad Ben-Yossef
2017-05-28 14:40 ` [PATCH 03/12] staging: ccree: remove 48 bit dma addr sim Gilad Ben-Yossef
2017-05-28 14:40 ` [PATCH 04/12] staging: ccree: cleanup lli access macro Gilad Ben-Yossef
2017-05-29 14:41 ` Greg Kroah-Hartman
2017-05-29 17:32 ` Gilad Ben-Yossef
2017-05-28 14:40 ` [PATCH 05/12] staging: ccree: remove cycle count debug support Gilad Ben-Yossef
2017-05-28 14:40 ` [PATCH 06/12] staging: ccree: move request_mgr to generic bitfield ops Gilad Ben-Yossef
2017-05-28 14:40 ` [PATCH 07/12] staging: ccree remove custom bitfield macros Gilad Ben-Yossef
2017-05-28 14:40 ` [PATCH 08/12] staging: ccree: remove unused struct Gilad Ben-Yossef
2017-05-28 14:40 ` [PATCH 09/12] staging: ccree: use snake_case for hash enums Gilad Ben-Yossef
2017-05-28 14:40 ` [PATCH 10/12] staging: ccree: drop no longer used macro Gilad Ben-Yossef
2017-05-28 14:40 ` [PATCH 11/12] staging: ccree: remove dead code Gilad Ben-Yossef
2017-05-28 14:40 ` [PATCH 12/12] staging: ccree: whitespace fixes Gilad Ben-Yossef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170529143728.GA12428@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gilad@benyossef.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ofir.drang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox