From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751141AbdE3Q74 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 May 2017 12:59:56 -0400
Received: from mail-pf0-f175.google.com ([209.85.192.175]:35697 "EHLO
        mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750938AbdE3Q7z (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 May 2017 12:59:55 -0400
Date: Tue, 30 May 2017 09:59:47 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: x86@kernel.org, devel@linuxdriverproject.org,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Jork Loeser <Jork.Loeser@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>, linux-kernel@vger.kernel.org,
        Steven Rostedt <rostedt@goodmis.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Ingo Molnar <mingo@redhat.com>, Andy Lutomirski <luto@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v5 02/10] x86/hyper-v: stash the max number of
 virtual/logical processor
Message-ID: <20170530095947.4cc19990@xeon-e3>
In-Reply-To: <20170530113424.15687-3-vkuznets@redhat.com>
References: <20170530113424.15687-1-vkuznets@redhat.com>
        <20170530113424.15687-3-vkuznets@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 30 May 2017 13:34:16 +0200
Vitaly Kuznetsov <vkuznets@redhat.com> wrote:

> diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
> index 04cb8d3..bdcc433 100644
> --- a/arch/x86/kernel/cpu/mshyperv.c
> +++ b/arch/x86/kernel/cpu/mshyperv.c
> @@ -175,9 +175,15 @@ static void __init ms_hyperv_init_platform(void)
>  	ms_hyperv.misc_features = cpuid_edx(HYPERV_CPUID_FEATURES);
>  	ms_hyperv.hints    = cpuid_eax(HYPERV_CPUID_ENLIGHTMENT_INFO);
>  
> -	pr_info("HyperV: features 0x%x, hints 0x%x\n",
> +	pr_info("Hyper-V: features 0x%x, hints 0x%x\n",
>  		ms_hyperv.features, ms_hyperv.hints);

>  
> +	ms_hyperv.max_vp_index = cpuid_eax(HVCPUID_IMPLEMENTATION_LIMITS);
> +	ms_hyperv.max_lp_index = cpuid_ebx(HVCPUID_IMPLEMENTATION_LIMITS);
> +
> +	pr_info("Hyper-V: max %u virtual processors, %u logical processors\n",
> +		ms_hyperv.max_vp_index, ms_hyperv.max_lp_index);
> +

I understand as developer why you may need to log stuff.
Do we really need more logging here? Why not pr_debug()?