From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751340AbdE3KJa (ORCPT ); Tue, 30 May 2017 06:09:30 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:38761 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbdE3KJ2 (ORCPT ); Tue, 30 May 2017 06:09:28 -0400 Date: Tue, 30 May 2017 11:09:25 +0100 From: Lee Jones To: Benjamin Gaignard Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/15] mfd: motorola-cpcap: use devm_of_platform_populate() Message-ID: <20170530100925.ebkszro65iscf2ea@dell> References: <1496072763-31209-1-git-send-email-benjamin.gaignard@linaro.org> <1496072763-31209-11-git-send-email-benjamin.gaignard@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1496072763-31209-11-git-send-email-benjamin.gaignard@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 May 2017, Benjamin Gaignard wrote: > Usage of devm_of_platform_populate() simplify driver code > by allowing to delete cpcap_remove(). > > Signed-off-by: Benjamin Gaignard > > CC: Lee Jones > CC: linux-kernel@vger.kernel.org > --- > drivers/mfd/motorola-cpcap.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/motorola-cpcap.c b/drivers/mfd/motorola-cpcap.c > index 3cab58a..d2cc1ea 100644 > --- a/drivers/mfd/motorola-cpcap.c > +++ b/drivers/mfd/motorola-cpcap.c > @@ -260,17 +260,7 @@ static int cpcap_probe(struct spi_device *spi) > if (ret) > return ret; > > - return of_platform_populate(spi->dev.of_node, NULL, NULL, > - &cpcap->spi->dev); > -} > - > -static int cpcap_remove(struct spi_device *pdev) > -{ > - struct cpcap_ddata *cpcap = spi_get_drvdata(pdev); > - > - of_platform_depopulate(&cpcap->spi->dev); > - > - return 0; > + return devm_of_platform_populate(&cpcap->spi->dev); > } > > static struct spi_driver cpcap_driver = { > @@ -279,7 +269,6 @@ static int cpcap_remove(struct spi_device *pdev) > .of_match_table = cpcap_of_match, > }, > .probe = cpcap_probe, > - .remove = cpcap_remove, > }; > module_spi_driver(cpcap_driver); > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog