From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751266AbdE3NVm (ORCPT ); Tue, 30 May 2017 09:21:42 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:52208 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbdE3NVk (ORCPT ); Tue, 30 May 2017 09:21:40 -0400 Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=fb.com; Date: Tue, 30 May 2017 14:21:14 +0100 From: Roman Gushchin To: Michal Hocko CC: Balbir Singh , Johannes Weiner , Vladimir Davydov , , , Subject: Re: [PATCH] mm: bump PGSTEAL*/PGSCAN*/ALLOCSTALL counters in memcg reclaim Message-ID: <20170530132114.GA28148@castle> References: <1496062901-21456-1-git-send-email-guro@fb.com> <20170530122436.GE7969@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170530122436.GE7969@dhcp22.suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [2620:10d:c092:200::1:255a] X-ClientProxiedBy: AM5PR0201CA0024.eurprd02.prod.outlook.com (10.169.248.34) To DM3PR15MB1082.namprd15.prod.outlook.com (10.166.160.136) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3PR15MB1082: X-MS-Office365-Filtering-Correlation-Id: 6c09e1d3-484b-42a7-c4b1-08d4a75ec8aa X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:DM3PR15MB1082; X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1082;3:s2klP5wNQDL+Qd79AuKhTEaS0mgXzq+mTxUDfodiyo5lDAKcCy5hwHa/yRcyIFEjA9GyEMkYhbf8SBNHeBW4ZuSw1nrONnih8YTmbury1mJ/L7oT3dWPvJyclrxFRLhKCWf7DWxywDdPr2bQwzPJqlM5M2U5NbWILP+vK5DuObPEnWqXNbUAI0QXD9AczBkO11RdGtpi39Yv+mI6fK8hK635UipET9b2wQXaPerbx6w/ZLTE8V3SQaQxHrlOZIKPYflppDy6jneXhF5PauRq2/lI6NdtBWm3wAsOURy+9rZQCGZpDJ75WjpDY30bbuLrUu1E7pJoyyfJjS8QqcU3Ow==;25:GwtzjZFna1WTEkd/xhWFNp2RmB+WwiBfQAgBrIqMrlook0JENz0qg4pGFjhBNeyhuRqDdUvra9Sgi2MF4/KyLXZafyc6F5zhCJeD8L5KHp2Sj8zWSYRMEYwPlAdDK+/2WRFhSfl0TemNLWzEId4KXC4GmGJiXiazYZ+Qt0XZEE50+gR37fU1Jq8Rult0PUMDf48GT9EnkY+WMrp5JdgKJvFamw5s6mx1WuOzU2rXoKwvhfSiSeB96v0gwRFrBgv74W9ZDU3PkJfOKfnVr3KVBw6Mz4N4TdKjs/GJE0aJKBx9XxW/M7P1X5dn7wzAmjE+aBPpfVtVge3McX1mZNoRGfweik5fmELEgbLE46Xn5O2olKmmqqKvIBMY4SPHv47biYf9Lm0vnFVYRpWDYE7xRVEfog7A44dl/ZXf99uNfXpof5GeU9cl8JazD7cNTLmfVSIJXi5JIBE69bPplzQUHzA8dnCf/XEsuT5L7Hn1xdQ= X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1082;31:BVUmuECpjo0P29KydoLAIPDuCFNVs02m+8o1A+8UzJ5kNrL4gb/SOta+97uyzeanzFtUplpaY64Pyw+lKYKtOZ7oR/fEMefqOvQthHAu2m/qmCcA49vkcp7Hru9QlOrt/jJCXQppj15D4gEQBjEpyvmK+GESi8bOM6p6s2JkpLc4OUABvFJs6t68A24X13b7/4obxRnMAaJ1yzKYFm7GpYywCMTS6KDJCOrUuaBe2hw=;20:CwQf9wNJK5UuXFhx819v0ys/Ni+YX1HAUXlu0WK47SY91Pe0MPxhE3U3rBK+rJGdqFaFwW+otPHrP8h9LyZwo2Fm4zGJYklPqGlsCA1Nb8Etd6sCx4/CMHok0z6G6FypGLDX0W0f0C68HLdn8RRB+m3UFx9Bkw8WNw2jzAOuvf3Sh4AO5YdQ9dBcnWq2MGbJxpCxzNxBvz445FKLmkJnBy1GoQ+esOyivIAqXlAshLZKtO035ddcEh0NCxtb3HiK0/wtzHrlO81ailcACTuNVNfuCwh+KbTvl9tgiylExBMrv37Q4U81l32mzc5F4ColpJi7jBx8YwX4pstVMTIPZTacnfjd5FvVW9z5dSUJVCYQuB95vHsaSY+cyNWaMg0SMtQ2QdkQKl6QmAaRwSU1sd0l0O8E2r18mNsWxoCO+LD7dIoejUUbMpfJcQ8KAys/Gqwhae1prIfiiV1rnRgL3ZuBivo5ARrDUhKZMPpx3DkJEbp+8/jHGoADN7P1L1Bz X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6041248)(20161123564025)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148);SRVR:DM3PR15MB1082;BCL:0;PCL:0;RULEID:;SRVR:DM3PR15MB1082; X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1082;4:G0mk64TCzuCCW4egZjEhgwvEymoBbCEslDScyoqWOQIxUy/zIcnnz8UQeXxr7s3dEc5Nk9Y8+sI4Kkt+W/7vAnP8lTjbSLAhUp4a2eVJDxWLKz4HibWQusqE6UCnu0y8Mp9YTODJZedtOJHnnadoinGRafA+f1Avuhi2trKr4bqd1Dn4t1h8aCkcrBTQ1OE27XEYdF3TjLO0RwJoqbHGhwhiyHQFKxgJZTGXYdmFKJJIOP0Lq5TP4Yb2VdIrgRlfZOLVzpJuf7khSDBq4Mr/rOJyXTnfAwzORYJymdFnbeAhtUnBSTJdsyUY1iuZaL13Rl9ObfRtOmGclOhhpFWmoJqDoAcbqx0VzoFowqR/YjO2ldIGjvIGuOFjQj+/aufY8Ufr6K36ymTGf2aRmceWsYHuFTQyHamwFwh/2hAlshUgZzsy0kqq9byp0/YLXzhTISL2uJAZyysez19LAiyyn5nngVxIlyemQdTQEVElgLN+agAiwbB2BKxyrrlgAOoGw57DC/8RvggAP+7spMaW0iLzH4AhfYD5ZUeHWyLme5rxAfMz+MzQCmapSfs2+C7v4ZvXCMljl5YCO8VPOgSD7E4jvRlzamgUgGP8kDhf5iMOF+dZR+u7CVtIZQ+U1n3DRgLGXqFGtntJrzug2ztGClk/EQutXjksrUwc49AI1ZELwfLmcDCBpkkGSZqeZknPtBUCHpkUepNQGZno1cCXS6dnsHBeFZCocGboYOxLtMW1n+Vb6qxZ4w7ScR9452dfF2E+HZ7FPt89GKgJRCNzXjokMI/RNxVl2VDJcY2nAP0= X-Forefront-PRVS: 032334F434 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(39840400002)(39410400002)(39400400002)(39450400003)(39850400002)(377424004)(24454002)(2950100002)(50986999)(6916009)(54356999)(6666003)(76176999)(6496005)(6246003)(53936002)(966005)(47776003)(110136004)(38730400002)(33656002)(2906002)(478600001)(9686003)(8676002)(229853002)(50466002)(6116002)(1076002)(54906002)(81166006)(6306002)(55016002)(189998001)(7736002)(305945005)(5660300001)(86362001)(25786009)(83506001)(4001350100001)(42186005)(33716001)(4326008)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM3PR15MB1082;H:castle;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM3PR15MB1082;23:NFYBIWSnVcgmldLhFbEV4Suzs6fowRE+QP97phWiG?= =?us-ascii?Q?cBAFAZ+7lXd80KOfIkaXqmVc+Y35mGQSWL4c77OVw2h9j+QZns78cuqmOy53?= =?us-ascii?Q?NhZqlG1NPksh0xByqKALhl9saWERQCp5HvxrHSzxbXv0RNmw0KlNOPOkYYLX?= =?us-ascii?Q?VWfEfsCaycKK5tQgZqQGuGB8js5cOuONZJ7Dr9nX9/qXCiXnga8JBGgYH/tz?= =?us-ascii?Q?E2GzsT2ciMLzwXO6bgONyW9gfDVyWQjdG7dWK/05gyLlIgmXbxFzekbZqNwP?= =?us-ascii?Q?H6MRO5qB5+hgI/AHmxjUbOa4G91VjxWfxlDb+y3eb/8aUcm0v0y0973uFqup?= =?us-ascii?Q?dOaCoZrlyRKNoidZsl7miLoNZ8nl1ppZPUi94TEd+gKNpFgEei4PNs0+dO/u?= =?us-ascii?Q?G9QYmhVMjRqVgN9sjBThSdUbJIt1r0hEcWWmuL7+l8zXXXCEb/vOQwGb89Ph?= =?us-ascii?Q?uUY3yuS+m90rwh20zgnj0s9Q9r5pR4chR98W+WguVi1idQ50NGV8tWCv4Huf?= =?us-ascii?Q?wM95136WbeaAWwDoA5fc95NQT5uXipZIKQ79jHi7KfA0EEK5IozgP0im9Cmf?= =?us-ascii?Q?Vfu77AUGGc2yL+SRb2U6blRBBcA4FZEVmwkksJNS4ZS+66cgNdXQCaA+agVc?= =?us-ascii?Q?pIUSArCTi0mK2DzkOOJ/q0bvJ/wPDVKMyKxTeKnOszq3T7VA7T8afZ4TXQcX?= =?us-ascii?Q?NGNQ9cDG4HUtDWieF4mUwvwkAY64GPzqx3G7nxvz6+rcbpAQdYEucQ6AGBL8?= =?us-ascii?Q?3/aDFie9P80lJpJrmH7CEUlXGvb3IKYUEKsGpb86q6pRDBR6MLsaRrMWYzaJ?= =?us-ascii?Q?e8JYFcGFj7IfKfogNP7s4QwKXAT17Spt6S+KwiUeyf7FtyP4FY/SHhuDe46C?= =?us-ascii?Q?Tk/vqE2lLI7FHzzIQX+ysibPpPvA3rPmlfkCUa++ZQnPNTIRtGclS9BVoVCM?= =?us-ascii?Q?op1XHoed7QeoQOq2aE6A146Zf26LQzcZCzukdgnFksxGAs/BzxRDB3btoOOE?= =?us-ascii?Q?JmcOndeSZ6oeBRaR7ZFcBBBvYvR6xKn5Xpyr8z0zzx/pfehTD/wi37/pWHiS?= =?us-ascii?Q?yLQm+W2OWbWJoEc0npVuejqw6fyobu3acloHNkMg9LyxigVT7pAM2NgTBDUU?= =?us-ascii?Q?zy2RX407OcmOYgVgFOAgY1NugUFFY756yxDs6kjfijuSnXRe9VcIyibpHRta?= =?us-ascii?Q?lCXaPHvKkyz+6gSV4KoUUr9vc1d6fahE/AW?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1082;6:ALcgqSpTyBxnEFOx9vU9goDkADc1I+F0Hvf58eJ3OAeTuwxmqeq03IhSH2GEtA9W12znPB+RQFo3kMeHrzJ42RQKNwRAuYhCY366JtM6WZe4CSFVUwim6A4yLMjZYD5WCVu3RQn1NcLdnGxYSkT7AL5/h0WpWWgkyfZ3+1dwoF6hdI+rj5Iy8lDoVm7RFJhbGPvp7rYqtztne6LiAFYSdo6e97o2et69PWUymQU86v46hh2zToSOJC6fraFuTx9AvNAhHnZYu6eFLwZE8PNgWrjVOcw60sO7fLjjsz+JgvXsGJMVR0imHO3K0/Z+abLpac0+PsWJBUe77aDqC7CPK6cLryLkCQeo+/U3+SfN6w9PFeMwSS0Ko8mMS9jcQwEjsvytv7MdrXiXpBMQv2zF6ggJiJXmycN0fQjk83fxbpoLtQ1xpw8MBEuikB2euyVr+DPV1T1afQARM8UEBDvFhzGI1BKQPPnxdXegQm7nnFUWN9ZA8zRRjoX5eO8qkhLbNwydAz1xF9j2vUNMrdZStg==;5:vz9gL78chCEKiRln3wMRSZGdTvwohnFkl9XYyKi2TRA4dIou+K4ZeEewpdAPzWK3iW5Xp9BnNK122svdUh5bJIjwD5TkYwoRoncHaJxBgz0VbtLwPooSjviULA9ABLxcc0jtYe1wAoKhnNcFzdlHmQ==;24:z+Cj3OzxPzcQyMeIzX40OKfW3c9Jknvvhq+YkQqnWWGcY7xjfOs6yHuy9baXqubPq9ZPWQFQ80PSoyxWUvCtmnifqAgq1W+dLChYvZHOluM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1082;7:edFZqD8avnAGNS7/6cXLbfze+etOm3/U3jYi9q6TqiwXLy+W6CbkD3b0irFsCH6a1WDwaVfF/Cr6iQsVLcPOb7z3hqf3yG/Ys8OL860wlSGz8HINUIMWSS3N6U23wV9oXFcumyAKTtmnlbf2AhCpvTT4rJx+g2jJ9+oNuTRsIx2CXEarr1hgFFr3m8wE/EU2LoqxyuK/VnkN0qdFBNETvqJBsghtPGm/bwn0SGtaZeG03L8dKnVM9DFNVsoiWEYITq1O7npnWVVlQmOGLdiM8g+TtqJ2BHlsKZvA/WZp+vbVL7h9nZQ+ukVAPVdBDvuCnjdrwoI08Qh0/QnKZYgz+A==;20:FXiEpns3OahFEeyqzxR2iAwoluOM8abV/1PCAKB/cMQADrvxaKCdJuqehlNP5q+6IUahihploT1x4aecbUuoVl4m8JwLXJdqU2kF7ZzSjIcEKeBiUhLOWaX6odGa3wEQWo0eCJu3tP6VXRum978HzGQXDXdetnKz4rP7KpTAYVo= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2017 13:21:28.9137 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR15MB1082 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-30_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 30, 2017 at 02:24:36PM +0200, Michal Hocko wrote: > On Mon 29-05-17 14:01:41, Roman Gushchin wrote: > > Historically, PGSTEAL*/PGSCAN*/ALLOCSTALL counters were used to > > account only for global reclaim events, memory cgroup targeted reclaim > > was ignored. > > > > It doesn't make sense anymore, because the whole reclaim path > > is designed around cgroups. Also, per-cgroup counters can exceed the > > corresponding global counters, what can be confusing. > > The whole reclaim is designed around cgroups but the source of the > memory pressure is different. I agree that checking global_reclaim() > for PGSTEAL_KSWAPD doesn't make much sense because we are _always_ in > the global reclaim context but counting ALLOCSTALL even for targetted > memcg reclaim is more confusing than helpful. We usually consider this > counter to see whether the kswapd catches up with the memory demand > and the global direct reclaim is indicator it doesn't. The similar > applies to other counters as well. > > So I do not think this is correct. What is the problem you are trying to > solve here anyway. This is a follow-up patch after the discussion here: https://lkml.org/lkml/2017/5/16/706. I can agree with you, that a per-cgroup ALLOCSTALL is something different from a global one, and it's better to keep them separated. But what about PGSTEAL*/PGSCAN* counters, isn't it better to make them reflect __all__ reclaim activity, no matter what was a root cause? Thanks! Roman