From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751539AbdE3OLx (ORCPT ); Tue, 30 May 2017 10:11:53 -0400 Received: from mail-by2nam03on0043.outbound.protection.outlook.com ([104.47.42.43]:47872 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751004AbdE3OLt (ORCPT ); Tue, 30 May 2017 10:11:49 -0400 Authentication-Results: caviumnetworks.com; dkim=none (message not signed) header.d=none;caviumnetworks.com; dmarc=none action=none header.from=cavium.com; Date: Tue, 30 May 2017 16:11:35 +0200 From: Robert Richter To: Geetha sowjanya Cc: will.deacon@arm.com, robin.murphy@arm.com, lorenzo.pieralisi@arm.com, hanjun.guo@linaro.org, sudeep.holla@arm.com, iommu@lists.linux-foundation.org, robert.moore@intel.com, lv.zheng@intel.com, rjw@rjwysocki.net, jcm@redhat.com, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, sgoutham@cavium.com, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, geethasowjanya.akula@gmail.com, devel@acpica.org, linu.cherian@cavium.com, Charles.Garcia-Tobin@arm.com, robh@kernel.org Subject: Re: [PATCH v7 0/3] Cavium ThunderX2 SMMUv3 errata workarounds Message-ID: <20170530141135.GV16981@rric.localdomain> References: <1496145821-3411-1-git-send-email-gakula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1496145821-3411-1-git-send-email-gakula@caviumnetworks.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [92.229.86.36] X-ClientProxiedBy: AM5PR0101CA0008.eurprd01.prod.exchangelabs.com (10.169.240.18) To SN1PR07MB2352.namprd07.prod.outlook.com (10.169.127.18) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PR07MB2352: X-MS-Office365-Filtering-Correlation-Id: 6a286fd2-fa32-4caa-ab68-08d4a765ce5c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:SN1PR07MB2352; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2352;3:m8UNzMLXkIoL6GEWL+gyWlRqFJOKKgFRuPIidSRz9DBub3YgdTPhRAxGaQD2UfBfzuEs4njC1B9CtyNChq7bl9OzhQq9b4J/zZGGtqYeGs5EsERpsYyGayQfwyIt6HK7RTJ+7UHa/vcBlYVM6jxA9p82KMYKrI0cjFlyoMxn6LQ1Nmu2JWxCzDF483czXL5gdmOq/TwtkIr23nCg3W3N6in3R6b3EhQFdYcZsfrSXpHs0lAREb9PJxIeNmzTs0f9KzvecmQIZDhNwaspbkWTzZTsQjE0Mstz5AJoFzCdmCAzXkhExJJz8uoycsVN9WaFD03vWo7FHM+0vidLaCJ2Lg==;25:5zhGpwT9DnQLxSOz/zSHhlA6P9UxGDyiNjooNVnVpiE3kD817gzossqpwaeqb+qzfTQN7o4G7PbZ4/dEnsbQNUNPGhzIJgZvfohG3A0kcywCKo0/A2MldD969Tj7m5y0nRoXjibjsy7tyb6YSk/q8KSDFFZ8ajG0U8974AlUjVjchZgRQZgbjGgYfzYcSk7Z7wXV/7ecORfvA1P4xdvDroe5j77hfV3E9AiI1v3djAHgbeoTm9AeGSEsFRUYouAVw2cHHsFvnf4ruvRdP2Oe3SNaYnTZrZo/wtWwJiu4uGQOYmo5Lj/AouRfVgeeSHAM9RHWeufiLTJ7oC0GZFWFeBqFGxfwToP0A8nymk19lNaYe5o7li1Pheboo1uX2G47vR6rBYkYE8UqQT3TKlB24XIuYGEK5oX+5Or+4EmDomTCYNLpX8Pm8pSFU4eKXZr482C1bzyxkhcK3IfNC72fi/HZNyAhqi8ww1yC05V0g6g= X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2352;31:UJf5nPdxzUei3BmF4peQO4U/qpLZluh9BZmHFH9/UWf8bKUmPfS6BkJFxtzoX+OjjA7jDybLPkR9kbePnGTi/gNOPPZ2davp2jKTohWw1fXAMZfu7aaXFC4hyIiEgmvKpTbtauCxVrn3pM9vxlMRADhPlSxiydeWj4uywbfgnnEfJbt+KgnmVmk2ozTnzMlDbUTJbvxX6PLYKh0AB4F4dWHD6cHHAHT29xgCn+9VuRM=;20:hjQCQgp65cDEHZa27bnAo4k0hL0vK8vimA+6MreZtHbaR6gKMNEl+ghi5pdF9X5P9rsOI4JgR4Ii8H+x4pVTAHp64fjRQbo5vwAsfeif3eyea2QuQkVj4mxGNIANbPNWc8e8e5AjOszjWzRkz7OWG5hssycv/bhN4oXh75Y0TGw9tExkS6LMl0UaQG93fGMKWwYr+5tn0AEESyu7X3ZdryxnbrfTqaMi2onF+CuWWqkHfmw/mEUcVBklj1z2M26VHwLcYR650YsD1vg6hPtNFpeoZDTO7+Bw6lVZ86cwnses6SDx7/rRobfTrQYAK5TeHXZPZrHx6rZDRjfUHG59PIXgV3TscA8bviOXkBVZO/kzd2yPKmmdmKcKtIqT5eBTfKm2HlClaZye4cfHer+JlHDZ/fAlWK1YT2uqhqAMUpryj7ezTMCicDRPvzT0lLWFk8ilvjAZQD0CjqynlCGqOg+Y1uu1EwWjP5KxCyyTww2YrElQoKfhHTJDUn8K7+mV X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700073)(100105000095)(100000701073)(100105300095)(100000702073)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(100000703073)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123562025)(20161123558100)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(100000704073)(100105200095)(100000705073)(100105500095);SRVR:SN1PR07MB2352;BCL:0;PCL:0;RULEID:(100000800073)(100110000095)(100000801073)(100110300095)(100000802073)(100110100095)(100000803073)(100110400095)(100000804073)(100110200095)(100000805073)(100110500095);SRVR:SN1PR07MB2352; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN1PR07MB2352;4:otClJR21emLNyhLqYxVJBUdO6QNmgNjO+FJnbKuHY8?= =?us-ascii?Q?DyOhD+ZWUqv/WGWZR6Ff1RVRBRknIhLZjVSyyvWrtWEnB1fuKHOod6AO5DZa?= =?us-ascii?Q?EYVvFXrE7TXhkE7cZ+bFt+n0Fp0fGVvha2gbO3aQGi36n2mgZ0gyZdvyzjKH?= =?us-ascii?Q?H5+SXYkt1r+VK2UGKbOoZ3loOAjiMeM6AE/vnQuS2VYCFHnrzaz8vorRZPiu?= =?us-ascii?Q?WT4fpfvs58+QZI/x8BwZEdzY10K0X9Ce2tfFQGvEI4p6wuEvUvQnchRN5mc9?= =?us-ascii?Q?QfjcYA9KgNWbW4oYlWrEyqM0GuLHc6zxm/RPeJ7hSSGTzxR6ltilGdkLU45F?= =?us-ascii?Q?mBjVrIKkXZFmeRGJMjoOXSlvASc9NmQe3j56Qs9OJDF6sZ7dCnffWY+hTdjD?= =?us-ascii?Q?4JFDt3Vbh/wXl1l/YjJjIsEg9n/10/QN+8a1ZA6npX1GoMCVdWFqAesxQ9zz?= =?us-ascii?Q?X2gZuliSIrmW6eDwJ8DKKpwaKWuvjlVhadsDMJuJPQe5cWHzo81Xs9u1RIMT?= =?us-ascii?Q?sLNxvBArlLZu9BuriuRmxW8JAwVVe7RbuGPMP/RV8/DVMIGBo8qSI8ZkK2XU?= =?us-ascii?Q?NDQobfKgZCsD6CHMoMUJ35JjEWQhDi3PlWHfMBrqNZ/pS2mOJzMMOA10hMCe?= =?us-ascii?Q?/mZQhFm9CTmWPYsyCEhp9YUNJ3bpxKCQMm2GKDwYh9hAQioTdEbfBL5j3t2j?= =?us-ascii?Q?kDSG+x+vKO9AMjwO/wO/D500CP1dJljgBjCt+nOlCD/AramgaO6/vOhcyXEC?= =?us-ascii?Q?z6ZpW5U1OQC8vlCcaKWxqPMEC63gEAnmcUd5kh5cny2/8t3w0dHsKh4XW2Vl?= =?us-ascii?Q?x8gH6HIb0oWjWdfsumb7dacl1U+Zw02uAV6avV6F7tiN379IoSxmWfqGsDQR?= =?us-ascii?Q?xn0K0v6DA2BiZ87b6tsAySQgmRgNtfOJtIJ99Gv6xf8xqBKvXEGaY9VQ+x/j?= =?us-ascii?Q?D3xPfgYjkFguogADIWDYbYzTaT1slo9FUpkMUyNrw3/DL7PPZ5I6IHL032pF?= =?us-ascii?Q?pWkkL9A0GrUPnK1mOmtU/P12c+lPOcm23E/aiiBqtPaIJseWZexRbYgAkZ+D?= =?us-ascii?Q?z4f25xR6wHU8qaJM/MyFN95oFPSBla2dS8PjVzC4iZje5hHeBkCHzQ4dIPjQ?= =?us-ascii?Q?1DI4310puOlY6g1k618HmrB/z7BNaL?= X-Forefront-PRVS: 032334F434 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39410400002)(39840400002)(39400400002)(39450400003)(39850400002)(24454002)(53936002)(55016002)(9686003)(33656002)(7736002)(305945005)(4001350100001)(81166006)(38730400002)(6246003)(47776003)(8676002)(42186005)(6506006)(3846002)(189998001)(86362001)(6306002)(66066001)(2950100002)(229853002)(50466002)(110136004)(72206003)(6116002)(1076002)(83506001)(4326008)(6862004)(5660300001)(53546009)(25786009)(478600001)(2906002)(54356999)(76176999)(50986999)(6666003)(7416002)(966005)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR07MB2352;H:rric.localdomain;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN1PR07MB2352;23:sMvg39wvdfZvX20Yku7ohrz79oYvw5q9+4Myo3A5t?= =?us-ascii?Q?E4xfux4GH2SNUpCS2k8ITf/4PgAuPFK+LiybyPkjJzIqmeR/vsdPRndMiIeh?= =?us-ascii?Q?Mf8IejAxW06u5lw9MAp7tsLI7BXBwUoonK8ULRZ7T0X5fnCYgLTsUCBM5eh7?= =?us-ascii?Q?OHgXfEK9pnzvlb6bnMpVOJLqkHWetLVvZZMllWDqUVQcOQLYqtW5bD2NNYOF?= =?us-ascii?Q?cOmGEr4hbyhOfCXnovypHNtZOuV0tNP12MCWsMsOMa8EHka/Zlcj3AC8VM/k?= =?us-ascii?Q?4iU1Jaa/7uJYvxxzD0pv0DrSvEHxcoQvl3TzpyWbHlI3na5CkjIyyV5eN8Dg?= =?us-ascii?Q?6BUwnVzt97zdTlluuppJfswYFkuRm0bbb2zP6TbaTitMX2ABy3YXNENWOMDW?= =?us-ascii?Q?mhTi9WvRAw4VJSqU2702dnncDu6BKEwzSrcYvFEagWK4Aiz+G0doEMcpHbF1?= =?us-ascii?Q?VPoaBQjQLGLkxvx6FZkIax2XYlZZtIXawkkXnqUQn+RUPcuT1V8xzY5FN7za?= =?us-ascii?Q?Dhi6xSo84FRLzDo9GPBM+WyEXSTi54n7ddxJAPY+Trih5p7hNVbeNKbO1fwj?= =?us-ascii?Q?Bcmc672oLz9EJKyNYXCt2Spq7YTcVhg8upBd3kMP6DRhb5Vg+bwh1FhcuvyP?= =?us-ascii?Q?RkJwfWyTieGOGEbetJf5UWfmmOoi4MmSDGj71j8+GpB4mGktR7ide7joF7ix?= =?us-ascii?Q?x7Vmc9D3llHGmv0H33VH5t8iIa28DBwhkycvApGlhrW43i7KTE/vT8SUBwcg?= =?us-ascii?Q?qGUNQS5mZqLyWb8P35G4kl+rhhEOqeH0TyP0p8qvThAX/H/NiYU7oH10Mebp?= =?us-ascii?Q?UDnrOAQ9SGmiXWF/NlN0iUnsHfqhBg626ku2/dOR6CRQrzv3O6OgK790wEkE?= =?us-ascii?Q?hWyGnISd0+CHkjITVYnwN6ECZmYTZG34iXnrpZ4pdbXvX5ibxnoZ1vWGQzFJ?= =?us-ascii?Q?oVz5B+MUcAb08d4/H6LrakYEWS++VJ3YJ3Md218y9oBXGuwIMryQRSV0Z82P?= =?us-ascii?Q?pnaulZwlEkWybcHU/nlf1MD+AsJj6VoK37UD9X2uHdD4bpvd+QaoFq9R95Q0?= =?us-ascii?Q?YFs9ML7sdUNeRhJwhIGLMyGIXyC/HN+t6htGr3RkMxgnzq+/Nc4WbBes8LMC?= =?us-ascii?Q?NHtMuu8J6KL1WOyRHStwxx85PNqqGBx5BzW80EcuGp7lhIu2ws59xilX6XE/?= =?us-ascii?Q?dOIj15h0uL+bo0rLCIHIk+UvcC1kk7Ydz5X?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2352;6:4Rk5lXOpxmMTTC4WcqYcLEBv4zOJ3zwYyPrnYuj/4am4Xdp9HjxehVjYj0Ah7fc1expU0rjBXUTDgEKnzNGZ29Sw92mylWzACTNznmDpZbyxeZHQrGIhRS8Eb/TpecizeLLyJ8wvZBwnh9ccCXsZkcQaHO/3RaXVUwukdFYTId3Xrx/+uP6gL5kVUFoDG+uzwwXxkZVd16YVzm3WzVgo45BHhGRK4TWvZruVpm2WEtqODcMM09yZh0kqFwa0jw2UsDiwMP5uvCzdxjHwL9AxU89SSWOEx6vWYZE/nBvWXF2ef7ErPqyQPXaoEWMcHg4NHy0lqWmsMGwnJml9UpXJeUfEXh7BKZGeOBZeZ75oBpUGVJJGv7wfxJcRw7QHhwBZuQIs98EmqjNZeNEyk8stkZgsyVSZCmmVA9CLt2oFgKlwRImpU+xi6J21Mz7CaJgannKa21azHj2/2vKe8VtYrPUn1MeSWAskmJ5y3aNSogFTcTZu+8JoJ/QwiVUaRF7tNiI/ZWJBBtbwYL2nzfPjog== X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2352;5:n8q2GfVobA7ciE0gZZ3IlbFacC9eJ7CEn9Rij0IXXunD2y2QKGxU9wL/7I44hneNXFvdgcv5umPM98Ur35xgqgYdPjbgghuisp91xAbV5rPDuWS0WxN2wbWJieT8E2X6Kt8lGr8IFBWakrqSpK/UA2MXbSJk1emrxvGn1SRdh4UTgtoarYYsBzRyWKAf0c0uYIxOfRdX43rMjqXwFR91lDmcjFcTSXMCBLsl0WLx+0V8PesIIHgcUlVxfaCEuJQp1mJT4IL0Wh5WVF28Y/XsYrr3KFZ6Uqxf4SB4wmo3vI5QTprkQThFMKG9B1aObJscTpSgXWXif55rxhueiVb28f02Lh1+sSIaOVcUwWGQY6/VZvzPVo0XaIa13+Sefiwmd+RgRkRp+YzZOJECHNIB6pUzJ7VDpLrxPxrz3rn5dCV0fpTKD57Lboq/wH7UZDOPZfpwdxc7LlhPwiicIvoeM/nCMt7L6WbGys5q2ujYsdxU6L/QKC5wRurohog9k74b;24:DlVsUADwEwAmcxUaM8wtewPFYWILyeGF9iTOGtGRE0JuCQqWZief7qhiyfBqBaRjJKBFspny7TE0u3XH/aNv3OTxDqALvAKpBA60TKslT1s= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2352;7:4/WF4jQ25gZ4toKgWDtdyvTk4P4VHKB0Lv0srfjMHKaN+fGlMHTfgKWfWYlJ8O7yrdQyMTHSbQJj/aqi1tGa1e9ukOmQqXKC3BwkAQxV5AP9VZQwMG+DdDGBoRcbAPudFwH8qi+qQ1xVgflLIqa4wPP9Uj3cTa2t6HjADtdQgxdWfwqeMK1ADLT1RLZP40xQaX5W4Lyj9azZ6joJDVC5uQoGxYqF3ilzU1KTxm34rpCngVUrfCw7vJREgSs/UU1ivKBJKg+Zj+SGvdKVzxlen20kfWHrfRvGIiadL+Yb9qllhdBWZVkjA1TC9nW4GIrrGNGehAk7gaY1/H774wpfvA== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2017 14:11:42.7349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB2352 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.05.17 17:33:38, Geetha sowjanya wrote: > Cavium ThunderX2 SMMUv3 implementation has two Silicon Erratas. > 1. Errata ID #74 > SMMU register alias Page 1 is not implemented > 2. Errata ID #126 > SMMU doesnt support unique IRQ lines and also MSI for gerror, > eventq and cmdq-sync > > The following patchset does software workaround for these two erratas. > > This series is based on patchset. > https://www.spinics.net/lists/arm-kernel/msg578443.html > > Changes since v6: > - Changed device tree compatible string to vendor specific. > - Rebased on Robin's latest "Update SMMU models for IORT rev. C" v2 patch. > https://www.spinics.net/lists/arm-kernel/msg582809.html > > Changes since v5: > - Rebased on Robin's "Update SMMU models for IORT rev. C" patch. > https://www.spinics.net/lists/arm-kernel/msg580728.html > - Replaced ACPI_IORT_SMMU_V3_CAVIUM_CN99XX macro with ACPI_IORT_SMMU_CAVIUM_CN99XX > > Changes since v4: > - Replaced all page1 offset macros ARM_SMMU_EVTQ/PRIQ_PROD/CONS with > arm_smmu_page1_fixup(ARM_SMMU_EVTQ/PRIQ_PROD/CONS, smmu) > > Changes since v3: > - Merged patches 1, 2 and 4 of Version 3. > - Modified the page1_offset_adjust() and get_irq_flags() implementation as > suggested by Robin. > > Changes since v2: > - Updated "Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt" document with > new SMMU option used to enable errata workaround. > > Changes since v1: > - Since the use of MIDR register is rejected and SMMU_IIDR is broken on this > silicon, as suggested by Will Deacon modified the patches to use ThunderX2 > SMMUv3 IORT model number to enable errata workaround. > > Geetha Sowjanya (1): > iommu/arm-smmu-v3: Add workaround for Cavium ThunderX2 erratum #126 > > Linu Cherian (2): > ACPI/IORT: Fixup SMMUv3 resource size for Cavium ThunderX2 SMMUv3 > model > iommu/arm-smmu-v3: Add workaround for Cavium ThunderX2 erratum > #74 > > Documentation/arm64/silicon-errata.txt | 2 + > .../devicetree/bindings/iommu/arm,smmu-v3.txt | 6 ++ > drivers/acpi/arm64/iort.c | 10 ++- > drivers/iommu/arm-smmu-v3.c | 93 ++++++++++++++++---- > 4 files changed, 91 insertions(+), 20 deletions(-) For the whole series: Reviewed-by: Robert Richter