From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751032AbdE3XEy (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 May 2017 19:04:54 -0400
Received: from mail-pf0-f172.google.com ([209.85.192.172]:34123 "EHLO
        mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750821AbdE3XEw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 May 2017 19:04:52 -0400
Date: Tue, 30 May 2017 16:04:45 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jork Loeser <Jork.Loeser@microsoft.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>,
        Andy Lutomirski <luto@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB
 flush
Message-ID: <20170530160445.54b29cb8@xeon-e3>
In-Reply-To: <CY4PR21MB0631FC0D2A80D34081DF3595F1F00@CY4PR21MB0631.namprd21.prod.outlook.com>
References: <20170530113424.15687-1-vkuznets@redhat.com>
        <20170530113424.15687-9-vkuznets@redhat.com>
        <CAHp75Vc22JkiHpSWsnG72BWOV=Oc4WgKBWp8Ly8GXzjcepC9jg@mail.gmail.com>
        <CY4PR21MB0631FC0D2A80D34081DF3595F1F00@CY4PR21MB0631.namprd21.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 30 May 2017 19:17:46 +0000
Jork Loeser <Jork.Loeser@microsoft.com> wrote:

> > -----Original Message-----
> > From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> > Sent: Tuesday, May 30, 2017 09:53
> > To: Vitaly Kuznetsov <vkuznets@redhat.com>
> > Cc: x86@kernel.org; devel@linuxdriverproject.org; linux-
> > kernel@vger.kernel.org; KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> > <haiyangz@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>;
> > Thomas Gleixner <tglx@linutronix.de>; Ingo Molnar <mingo@redhat.com>; H.
> > Peter Anvin <hpa@zytor.com>; Steven Rostedt <rostedt@goodmis.org>; Jork
> > Loeser <Jork.Loeser@microsoft.com>; Simon Xiao <sixiao@microsoft.com>;
> > Andy Lutomirski <luto@kernel.org>
> > Subject: Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush
> > 
> > On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov <vkuznets@redhat.com>
> > wrote:  
> > > +#define HV_FLUSH_ALL_PROCESSORS                        0x00000001
> > > +#define HV_FLUSH_ALL_VIRTUAL_ADDRESS_SPACES    0x00000002
> > > +#define HV_FLUSH_NON_GLOBAL_MAPPINGS_ONLY      0x00000004
> > > +#define HV_FLUSH_USE_EXTENDED_RANGE_FORMAT     0x00000008  
> > 
> > BIT() ?  
> 
> Certainly a matter of taste. Given that the Hyper-V spec lists these as hex numbers, I find the explicit numbers appropriate.
> 
> Regards,
> Jork

Keep the hex numbers, it makes more sense not to change it since rest of arch/x86/hyperv
uses hex values.