From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751395AbdE3SLC (ORCPT ); Tue, 30 May 2017 14:11:02 -0400 Received: from hydra.tuxags.com ([64.13.172.54]:48546 "EHLO mail.tuxags.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751348AbdE3SLA (ORCPT ); Tue, 30 May 2017 14:11:00 -0400 X-Greylist: delayed 420 seconds by postgrey-1.27 at vger.kernel.org; Tue, 30 May 2017 14:11:00 EDT Date: Tue, 30 May 2017 11:03:59 -0700 From: Matt Mullins To: Radim =?utf-8?B?S3LEjW3DocWZ?= , Gioh Kim Cc: andre.przywara@amd.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC] KVM: SVM: ignore type when setting segment registers Message-ID: <20170530180358.GA13648@hydra.tuxags.com> Mail-Followup-To: Radim =?utf-8?B?S3LEjW3DocWZ?= , Gioh Kim , andre.przywara@amd.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1496064244-14785-1-git-send-email-gi-oh.kim@profitbricks.com> <20170530125420.GA19724@potion> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170530125420.GA19724@potion> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 30, 2017 at 02:54:21PM +0200, Radim Krčmář wrote: > 2017-05-29 15:24+0200, Gioh Kim: > > If so, why type is checked when setting segment registers? > > No idea. 19bca6ab75d8 ("KVM: SVM: Fix cross vendor migration issue with > unusable bit") also moved the assigment up to initialize it before use > and I think that is enough. Was this perhaps intended to instead check for a zero selector, which is also an unusable segment?