Re: [patch 13/26] posix-timers: Rename do_schedule_next_timer

Thomas Gleixner
2017-06-01T20:50:47Z

On Wed, 31 May 2017, Christoph Hellwig wrote:

> On Tue, May 30, 2017 at 11:15:46PM +0200, Thomas Gleixner wrote:
> > That function is a misnomer. Rename it with a proper prefix to
> > posixtimer_rearm().
>
> Please also move it out of asm-generic/siginfo.h as it's implemented
> and used in generic code only, and there is no arch override at all.
>
> In fact it seems like asm-generic/siginfo.h should probably just move
> to include/linux/signinfo.h.

That's one convoluted mess.

# find -name siginfo.h | xargs grep 'include.*siginfo.h'

./arch/score/include/uapi/asm/siginfo.h:#include <asm-generic/siginfo.h>
./arch/powerpc/include/uapi/asm/siginfo.h:#include <asm-generic/siginfo.h>
./arch/sparc/include/asm/siginfo.h:#include <uapi/asm/siginfo.h>
./arch/sparc/include/uapi/asm/siginfo.h:#include <asm-generic/siginfo.h>
./arch/metag/include/uapi/asm/siginfo.h:#include <asm-generic/siginfo.h>
./arch/frv/include/uapi/asm/siginfo.h:#include <asm-generic/siginfo.h>
./arch/x86/include/uapi/asm/siginfo.h:#include <asm-generic/siginfo.h>
./arch/alpha/include/uapi/asm/siginfo.h:#include <asm-generic/siginfo.h>
./arch/tile/include/uapi/asm/siginfo.h:#include <asm-generic/siginfo.h>
./arch/mn10300/include/uapi/asm/siginfo.h:#include <asm-generic/siginfo.h>
./arch/m32r/include/uapi/asm/siginfo.h:#include <asm-generic/siginfo.h>
./arch/blackfin/include/uapi/asm/siginfo.h:#include <asm-generic/siginfo.h>
./arch/ia64/include/asm/siginfo.h:#include <uapi/asm/siginfo.h>
./arch/ia64/include/uapi/asm/siginfo.h:#include <asm-generic/siginfo.h>
./arch/arm64/include/uapi/asm/siginfo.h:#include <asm-generic/siginfo.h>
./arch/parisc/include/uapi/asm/siginfo.h:#include <asm-generic/siginfo.h>
./arch/mips/include/uapi/asm/siginfo.h:#include <asm-generic/siginfo.h>
./arch/s390/include/uapi/asm/siginfo.h: * Derived from "include/asm-i386/siginfo.h"
./arch/s390/include/uapi/asm/siginfo.h:#include <asm-generic/siginfo.h>
./arch/microblaze/include/uapi/asm/siginfo.h:#include <asm-generic/siginfo.h>
./include/asm-generic/siginfo.h:#include <uapi/asm-generic/siginfo.h>

Why the heck include uapi headers asm-generic/siginfo.h ???

Thanks,

tglx