From: Brian Norris <briannorris@chromium.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: jeffy <jeffy.chen@rock-chips.com>,
LKML <linux-kernel@vger.kernel.org>,
dianders@chromium.org, tfiga@chromium.org,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] genirq: Check irq disabled & masked states in irq_shutdown
Date: Tue, 30 May 2017 16:32:38 -0700 [thread overview]
Message-ID: <20170530233237.GA39733@google.com> (raw)
In-Reply-To: <20170530231956.GA25960@google.com>
Sorry to respond to myself. Thomas, your reply to another mail in this
series helped me to notice:
On Tue, May 30, 2017 at 04:19:58PM -0700, Brian Norris wrote:
> Side note: for issues like the first problem above, I wonder why there
> isn't a flag that once could pass to request_irq() that suggests the IRQ
> should be initially disabled?
Is that what IRQ_NOAUTOEN is for?
> I know this wouldn't work for shared
> interrupts (but request_irq() could reject that combination, no?)
Hehe, but then I see this, for example, when grepping around:
drivers/usb/dwc3/dwc3-omap.c:
irq_set_status_flags(omap->irq, IRQ_NOAUTOEN);
ret = devm_request_threaded_irq(dev, omap->irq, dwc3_omap_interrupt,
dwc3_omap_interrupt_thread, IRQF_SHARED,
"dwc3-omap", omap);
IIUC, that's quite broken, no?
Brian
next prev parent reply other threads:[~2017-05-30 23:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 13:17 [PATCH] genirq: Check irq disabled & masked states in irq_shutdown Jeffy Chen
2017-05-26 13:20 ` Thomas Gleixner
2017-05-27 4:52 ` jeffy
2017-05-27 8:16 ` Thomas Gleixner
2017-05-30 23:20 ` Brian Norris
2017-05-30 23:32 ` Brian Norris [this message]
2017-05-31 8:38 ` Thomas Gleixner
2017-05-31 9:22 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530233237.GA39733@google.com \
--to=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=jeffy.chen@rock-chips.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tfiga@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).