From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751172AbdE3Xcm (ORCPT ); Tue, 30 May 2017 19:32:42 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:32984 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbdE3Xcl (ORCPT ); Tue, 30 May 2017 19:32:41 -0400 Date: Tue, 30 May 2017 16:32:38 -0700 From: Brian Norris To: Thomas Gleixner Cc: jeffy , LKML , dianders@chromium.org, tfiga@chromium.org, Johannes Berg Subject: Re: [PATCH] genirq: Check irq disabled & masked states in irq_shutdown Message-ID: <20170530233237.GA39733@google.com> References: <1495804658-12410-1-git-send-email-jeffy.chen@rock-chips.com> <592905F7.4010803@rock-chips.com> <20170530231956.GA25960@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170530231956.GA25960@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry to respond to myself. Thomas, your reply to another mail in this series helped me to notice: On Tue, May 30, 2017 at 04:19:58PM -0700, Brian Norris wrote: > Side note: for issues like the first problem above, I wonder why there > isn't a flag that once could pass to request_irq() that suggests the IRQ > should be initially disabled? Is that what IRQ_NOAUTOEN is for? > I know this wouldn't work for shared > interrupts (but request_irq() could reject that combination, no?) Hehe, but then I see this, for example, when grepping around: drivers/usb/dwc3/dwc3-omap.c: irq_set_status_flags(omap->irq, IRQ_NOAUTOEN); ret = devm_request_threaded_irq(dev, omap->irq, dwc3_omap_interrupt, dwc3_omap_interrupt_thread, IRQF_SHARED, "dwc3-omap", omap); IIUC, that's quite broken, no? Brian