From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751154AbdEaGY6 (ORCPT ); Wed, 31 May 2017 02:24:58 -0400 Received: from smtprelay0195.hostedemail.com ([216.40.44.195]:59708 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751113AbdEaGY5 (ORCPT ); Wed, 31 May 2017 02:24:57 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3873:3874:4250:5007:6119:6261:7875:7903:10004:10400:10848:10967:11232:11658:11914:12296:12740:12760:12895:13069:13095:13311:13357:13439:14096:14097:14181:14659:14721:21080:21433:21451:21627:30054:30056:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: frogs73_811438e81d25e X-Filterd-Recvd-Size: 2088 Date: Wed, 31 May 2017 02:24:39 -0400 From: Steven Rostedt To: Lu Baolu Cc: Vlastimil Babka , Greg Kroah-Hartman , Ingo Molnar , Mathias Nyman , tglx@linutronix.de, peterz@infradead.org, linux-usb@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 2/5] usb: early: add driver for xhci debug capability Message-ID: <20170531022439.54b93c69@vmware.local.home> In-Reply-To: <592E3817.4030402@linux.intel.com> References: <1490083293-3792-1-git-send-email-baolu.lu@linux.intel.com> <1490083293-3792-3-git-send-email-baolu.lu@linux.intel.com> <592E3817.4030402@linux.intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 31 May 2017 11:27:19 +0800 Lu Baolu wrote: > >> + > >> +#define XDBC_TRACE > >> +#ifdef XDBC_TRACE > >> +#define xdbc_trace trace_printk > > Did you forget to remove the #define XDBC_TRACE? > > > > Enabling this driver brings the "trace_printk() being used. > > Allocating extra memory. This means that this is a DEBUG kernel and > > it is unsafe for production use." message in 4.12-rcX dmesg. > > This feature is only for a DEBUG kernel, should not be enabled for > any production kernel. This was the reason I enabled trace_printk() > by default. Yes, it is perfectly fine to use trace_printk() for debug only configs. But if if you have it there and it is helpful to debug something that happens in a production system, you may want to look into creating a real tracepoint for the locations. -- Steve