From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751239AbdEaPhN (ORCPT <rfc822;w@1wt.eu>);
        Wed, 31 May 2017 11:37:13 -0400
Received: from mail-pf0-f179.google.com ([209.85.192.179]:34473 "EHLO
        mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750912AbdEaPhL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 31 May 2017 11:37:11 -0400
Date: Wed, 31 May 2017 08:37:06 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Alexander Potapenko <glider@google.com>
Cc: dvyukov@google.com, kcc@google.com, edumazet@google.com,
        davem@davemloft.net, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: don't call strlen on non-terminated string in
 dev_set_alias()
Message-ID: <20170531083706.1baa729f@xeon-e3>
In-Reply-To: <20170531125150.28798-1-glider@google.com>
References: <20170531125150.28798-1-glider@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 31 May 2017 14:51:50 +0200
Alexander Potapenko <glider@google.com> wrote:

> +	/* alias comes from the userspace and may not be zero-terminated.
> +	 */
> +	memcpy(dev->ifalias, alias, len);

You don't need a multi-line comment here.