From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751050AbdEaBbQ (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 May 2017 21:31:16 -0400
Received: from mail-pf0-f195.google.com ([209.85.192.195]:36394 "EHLO
        mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750824AbdEaBbP (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 May 2017 21:31:15 -0400
Date: Wed, 31 May 2017 11:31:04 +1000
From: Balbir Singh <bsingharora@gmail.com>
To: =?UTF-8?B?SsOpcsO0bWU=?= Glisse <jglisse@redhat.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, Dan Williams <dan.j.williams@intel.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        John Hubbard <jhubbard@nvidia.com>, Michal Hocko <mhocko@suse.com>
Subject: Re: [HMM 06/15] mm/memory_hotplug: introduce add_pages
Message-ID: <20170531113104.006dfc7e@firefly.ozlabs.ibm.com>
In-Reply-To: <20170524172024.30810-7-jglisse@redhat.com>
References: <20170524172024.30810-1-jglisse@redhat.com>
        <20170524172024.30810-7-jglisse@redhat.com>
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4V1VJjL004316

On Wed, 24 May 2017 13:20:15 -0400
Jérôme Glisse <jglisse@redhat.com> wrote:

> From: Michal Hocko <mhocko@suse.com>
> 
> There are new users of memory hotplug emerging. Some of them require
> different subset of arch_add_memory. There are some which only require
> allocation of struct pages without mapping those pages to the kernel
> address space. We currently have __add_pages for that purpose. But this
> is rather lowlevel and not very suitable for the code outside of the
> memory hotplug. E.g. x86_64 wants to update max_pfn which should be
> done by the caller. Introduce add_pages() which should care about those
> details if they are needed. Each architecture should define its
> implementation and select CONFIG_ARCH_HAS_ADD_PAGES. All others use
> the currently existing __add_pages.
> 
> Signed-off-by: Michal Hocko <mhocko@suse.com>
> Signed-off-by: Jérôme Glisse <jglisse@redhat.com>
> ---

Acked-by: Balbir Singh <bsingharora@gmail.com>

Looks good, from a CDM perspective, this means that HMM-CDM would continue
to use arch_add_memory()

Balbir Singh.