From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751149AbdEaNMY (ORCPT ); Wed, 31 May 2017 09:12:24 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:37218 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011AbdEaNMW (ORCPT ); Wed, 31 May 2017 09:12:22 -0400 Date: Wed, 31 May 2017 06:12:16 -0700 From: "Paul E. McKenney" To: Arnd Bergmann Cc: Arend van Spriel , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Brian Norris , linux-mtd , linux-wireless , Linux Kernel Mailing List , "open list:RALINK MIPS ARCHITECTURE" , Ingo Molnar Subject: Re: [PATCH] bcm47xx: fix build regression Reply-To: paulmck@linux.vnet.ibm.com References: <20170530112027.3983554-1-arnd@arndb.de> <7b6903a2-ce54-44f9-18ed-a14bd32069ce@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17053113-0040-0000-0000-00000350E966 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007149; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000212; SDB=6.00868204; UDB=6.00431441; IPR=6.00648083; BA=6.00005388; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015656; XFM=3.00000015; UTC=2017-05-31 13:12:20 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17053113-0041-0000-0000-00000744E9EA Message-Id: <20170531131216.GJ3956@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-31_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705310240 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 31, 2017 at 12:21:10PM +0200, Arnd Bergmann wrote: > On Wed, May 31, 2017 at 11:43 AM, Arend van Spriel > wrote: > > On 5/30/2017 1:20 PM, Arnd Bergmann wrote: > >> > >> An unknown change in the kernel headers caused a build regression > >> in an MTD partition driver: > >> > >> In file included from drivers/mtd/bcm47xxpart.c:12:0: > >> include/linux/bcm47xx_nvram.h: In function 'bcm47xx_nvram_init_from_mem': > >> include/linux/bcm47xx_nvram.h:27:10: error: 'ENOTSUPP' undeclared (first > >> use in this function) > >> > >> Clearly we want to include linux/errno.h here. > > > > > > unfortunate that you did not find the commit that caused this build > > regression. You could produce preprocessor output when it was working to see > > where errno.h got implicitly included and start looking there for git > > history. > > I did a 'git bisect run make drivers/mtd/bcm47xxpart.o' now, which pointed to > 0bc2d534708b ("rcu: Refactor #includes from include/linux/rcupdate.h"). > > That commit seems reasonable, it was just bad luck that it caused this > regression. The commit is currently in the rcu/rcu/next branch of tip.git, > so Paul could merge the patch there. Apologies for the inconvenience, not sure why 0day test robot didn't find this. Probably because it cannot test each and every driver. ;-) This patch, correct? https://lkml.org/lkml/2017/5/30/348 Thanx, Paul