Re: [PATCH v2 2/3] firmware: qcom: scm: Expose download-mode control

Stephen Boyd
2017-06-01T06:17:35Z

On 05/31, Bjorn Andersson wrote:
> On Wed 31 May 09:27 PDT 2017, Stephen Boyd wrote:
>
> > On 05/26, Bjorn Andersson wrote:
> > > In order to aid post-mortem debugging the Qualcomm platforms provides a
> > > "memory download mode", where the boot loader will provide an interface
> > > for custom tools to "download" the content of RAM to a host machine.
> > >
> > > The mode is triggered by writing a magic value somehwere in RAM, that is
> > > read in the boot code path after a warm-restart. Two mechanism for
> > > setting this magic value are supported in modern platforms; a direct SCM
> > > call to enable the mode or through a secure io write of a magic value.
> > >
> > > In order for a normal reboot not to trigger "download mode" the magic
> > > must be cleared during a clean reboot.
> > >
> > > Download mode has to be enabled by including qcom_scm.download_mode=1 on
> > > the command line.
> >
> > Why the kernel command line parameter? If we keep the kernel
> > command line param, perhaps we can also gain a config option to
> > make it default enabled or default disabled so that we don't have
> > to specify it on the commandline to get the feature all the time.
> >
>
> I put a command line parameter there because most people will not have
> the tools to catch what's given to them by this. Making it a config
> option definitely makes more sense than forcing certain groups of
> engineers to always slap a kernel parameter in there.

Ok. Sounds good. The commandline will still be nice to have to
override whatever is in the build without having to recompile.
And it sounds like the plan is to have both pieces.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project