Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever

Christoph Hellwig
2017-06-01T12:35:16Z

On Thu, Jun 01, 2017 at 03:28:18PM +0300, Rakesh Pandit wrote:
> > I think we need the NVME_CTRL_SCHED_RESET state. In fact I'm pretty
> > sure some time in the past I already had it in a local tree as a
> > generalization of rdma and loop already use NVME_CTRL_RESETTING
> > (they set it before queueing the reset work).
> >
> > But I don't fully understand how the NVME_CTRL_SCHED_RESET fix is
> > related to this patch?
>
> They aren't related. Sorry for confusion. I intended to answer
> another thread but instead wrote it here.

Ok, thanks. But I think the Point from Sagi that we should move
the state check all the way down to submit_sync_command still makes
sense to me.