From: Keith Busch <keith.busch@intel.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Hannes Reinecke <hare@suse.de>,
maxg@mellanox.com,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 6/8] nvme: provide UUID value to userspace
Date: Thu, 1 Jun 2017 08:47:26 -0400 [thread overview]
Message-ID: <20170601124726.GF2845@localhost.localdomain> (raw)
In-Reply-To: <20170601111750.20880-7-jthumshirn@suse.de>
On Thu, Jun 01, 2017 at 01:17:48PM +0200, Johannes Thumshirn wrote:
> Now that we have a way for getting the UUID from a target, provide it
> to userspace as well.
>
> Unfortunately there is already a sysfs attribute called UUID which is
> a misnomer as it holds the NGUID value. So instead of creating yet
> another wrong name, create a new 'nguid' sysfs attribute for the
> NGUID. For the UUID attribute add a check wheter the namespace has a
> UUID assigned to it and return this or return the NGUID to maintain
> backwards compatibility. This should give userspace a chance to catch
> up.
Sorry for the naming clash. Not sure why I didn't use the obvious name
for this file in the first place.
FWIW, tools should have been using the 'wwid' attribute, which returns
either EUI64 or NGUID so a unique identifier can be gotten from a
single file without checking for the existence of either. That should
help not break backward compatibility, but I've no idea if anything
actually relies on 'uuid' returning the NGUID.
next prev parent reply other threads:[~2017-06-01 12:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 11:17 [PATCH v2 0/8] Implement NVMe Namespace Descriptor Identification Johannes Thumshirn
2017-06-01 11:17 ` [PATCH v2 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures Johannes Thumshirn
2017-06-01 14:07 ` Max Gurtovoy
2017-06-01 11:17 ` [PATCH v2 2/8] nvme: rename uuid to nguid in nvme_ns Johannes Thumshirn
2017-06-07 13:47 ` Andy Shevchenko
2017-06-07 13:49 ` Johannes Thumshirn
2017-06-01 11:17 ` [PATCH v2 3/8] nvmet: implement namespace identify descriptor list Johannes Thumshirn
2017-06-01 23:08 ` kbuild test robot
2017-06-02 0:14 ` kbuild test robot
2017-06-01 11:17 ` [PATCH v2 4/8] nvmet: add uuid field to nvme_ns and populate via configfs Johannes Thumshirn
2017-06-01 11:17 ` [PATCH v2 5/8] nvme: get list of namespace descriptors Johannes Thumshirn
2017-06-01 11:17 ` [PATCH v2 6/8] nvme: provide UUID value to userspace Johannes Thumshirn
2017-06-01 12:47 ` Keith Busch [this message]
2017-06-01 13:01 ` Johannes Thumshirn
2017-06-01 11:17 ` [PATCH v2 7/8] nvmet: allow overriding the NVMe VS via configfs Johannes Thumshirn
2017-06-01 11:17 ` [PATCH v2 8/8] nvmet: use NVME_IDENTIFY_DATA_SIZE Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601124726.GF2845@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox