From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751201AbdFANAD (ORCPT ); Thu, 1 Jun 2017 09:00:03 -0400 Received: from www.llwyncelyn.cymru ([82.70.14.225]:34072 "EHLO fuzix.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbdFANAB (ORCPT ); Thu, 1 Jun 2017 09:00:01 -0400 Date: Thu, 1 Jun 2017 13:59:40 +0100 From: Alan Cox To: "Shi, FengX" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "matjaz.hegedic@gmail.com" , "keescook@chromium.org" , "Li, Fei" , "xlpang@redhat.com" , "Gortmaker, Paul (Wind River)" , "alex.hung@canonical.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] reboot: extend delay from 50us to 50ms for CF9 reboot Message-ID: <20170601135940.71e1d212@alans-desktop> In-Reply-To: <5111FC7902668B47AB76E3967882E2F26AD54985@SHSMSX101.ccr.corp.intel.com> References: <5111FC7902668B47AB76E3967882E2F26AD54985@SHSMSX101.ccr.corp.intel.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Jun 2017 02:52:32 +0000 "Shi, FengX" wrote: > On some emulator system, 50us is not enough to reboot the system > when write reboot_code to cf9. System will halt there by int3. Then your emulator is not emulating 8) and you really need to get whoever is responsible to fix it. If it's some kind of Intel internal emulator then I don't see why a hack for it belongs upstream either. You can also use existing boot options to force an EFI, ACPI or BIOS reboot with a standard kernel so you can deal with your emulator in your emulator firmware just fine. > Here extend the delay time from 50us to 50ms. > Such extension will improve the robustness of reboot, > without impact to the time of system reboot, which is already triggered by outb. On a system where a PCI reboot fails you add 50ms before the triple fault kicks in, so that statement is not true. Alan