From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751194AbdFAOZk (ORCPT <rfc822;w@1wt.eu>);
        Thu, 1 Jun 2017 10:25:40 -0400
Received: from imap.thunk.org ([74.207.234.97]:33126 "EHLO imap.thunk.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751083AbdFAOZi (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Jun 2017 10:25:38 -0400
Date: Thu, 1 Jun 2017 10:25:30 -0400
From: "Theodore Ts'o" <tytso@mit.edu>
To: David Gstir <david@sigma-star.at>
Cc: Eric Biggers <ebiggers3@gmail.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
        Richard Weinberger <richard@sigma-star.at>,
        herbert@gondor.apana.org.au, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-fscrypt@vger.kernel.org,
        Daniel Walter <dwalter@sigma-star.at>
Subject: Re: [PATCH v4] fscrypt: Add support for AES-128-CBC
Message-ID: <20170601142530.n6rfwuwwdzmkzyfp@thunk.org>
Mail-Followup-To: Theodore Ts'o <tytso@mit.edu>,
        David Gstir <david@sigma-star.at>,
        Eric Biggers <ebiggers3@gmail.com>,
        Jaegeuk Kim <jaegeuk@kernel.org>,
        Richard Weinberger <richard@sigma-star.at>,
        herbert@gondor.apana.org.au, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-fscrypt@vger.kernel.org,
        Daniel Walter <dwalter@sigma-star.at>
References: <20170517180850.GA91213@gmail.com>
 <20170523051120.15698-1-david@sigma-star.at>
 <20170523190041.GA132828@gmail.com>
 <54DA453A-BC92-466E-B3D2-6C67D7D32A90@sigma-star.at>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54DA453A-BC92-466E-B3D2-6C67D7D32A90@sigma-star.at>
User-Agent: NeoMutt/20170113 (1.7.2)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: tytso@thunk.org
X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 31, 2017 at 05:57:22PM +0200, David Gstir wrote:
> > The 'keysize > sizeof(salt)' check is now pointless and should be removed, since
> > we decided not to key the ESSIV cipher with 'keysize' bytes, but rather with
> > sizeof(salt) bytes.  So this function is compatible with any 'keysize', not just
> > keysize <= sizeof(salt).
> 
> You're right. Just let me know if I should send a new version of this patch with these minor issues fixed.

Please do, thanks!

					- Ted