From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751238AbdFBSc5 (ORCPT ); Fri, 2 Jun 2017 14:32:57 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:46490 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157AbdFBSc4 (ORCPT ); Fri, 2 Jun 2017 14:32:56 -0400 Date: Fri, 02 Jun 2017 14:32:54 -0400 (EDT) Message-Id: <20170602.143254.1054389009843287751.davem@davemloft.net> To: mst@redhat.com Cc: linux-kernel@vger.kernel.org, mpatocka@redhat.com, bfields@fieldses.org, jasowang@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH v2] virtio_net: lower limit on buffer size From: David Miller In-Reply-To: <1496415192-17031-1-git-send-email-mst@redhat.com> References: <1496415192-17031-1-git-send-email-mst@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 02 Jun 2017 10:51:18 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Michael S. Tsirkin" Date: Fri, 2 Jun 2017 17:54:33 +0300 > commit d85b758f72b0 ("virtio_net: fix support for small rings") > was supposed to increase the buffer size for small rings but had an > unintentional side effect of decreasing it for large rings. This seems > to break some setups - it's not yet clear why, but increasing buffer > size back to what it was before helps. > > Fixes: d85b758f72b0 ("virtio_net: fix support for small rings") > Reported-by: Mikulas Patocka > Reported-by: "J. Bruce Fields" > Tested-by: Mikulas Patocka > Tested-by: "J. Bruce Fields" > Signed-off-by: Michael S. Tsirkin > --- > > Patch tested, pls merge. > > changes from v2: > commit log tweaks to address comments by Sergei Shtylyov Applied, thanks Michael.