From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751134AbdFBFHJ (ORCPT ); Fri, 2 Jun 2017 01:07:09 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:33041 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711AbdFBFHH (ORCPT ); Fri, 2 Jun 2017 01:07:07 -0400 Date: Thu, 1 Jun 2017 22:07:03 -0700 From: Dmitry Torokhov To: Andi Shyti Cc: Jaechul Lee , Beomho Seo , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH v2] Input: tm2-touchkey - use LEN_ON as boolean value instead of LED_FULL Message-ID: <20170602050703.GA18657@dtor-ws> References: <20170601014736.17808-1-andi.shyti@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170601014736.17808-1-andi.shyti@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 01, 2017 at 10:47:36AM +0900, Andi Shyti wrote: > Commit 4e552c8cb5bc ("leds: add LED_ON brightness as boolean value") > has introduced the LED_ON enumeration value that can be used > instead of LED_FULL which has more of a linear value. > > Because the tm2-touchscreen doesn't have brightness levels, but > it's a simple on/off led, use LED_ON instead of LED_FULL. > > Signed-off-by: Andi Shyti > Reviewed-by: Jaechul Lee > Tested-by: Jaechul Lee Applied, thank you. > --- > Hi Dmitry, > > this is the second version of this simple patch sent here: > > https://marc.info/?l=linux-kernel&m=149062143701658&w=2 > > no changes, just added Jaechul's review and test. > > Andi > > drivers/input/keyboard/tm2-touchkey.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/tm2-touchkey.c b/drivers/input/keyboard/tm2-touchkey.c > index 485900f953e0..abc266e40e17 100644 > --- a/drivers/input/keyboard/tm2-touchkey.c > +++ b/drivers/input/keyboard/tm2-touchkey.c > @@ -213,7 +213,7 @@ static int tm2_touchkey_probe(struct i2c_client *client, > /* led device */ > touchkey->led_dev.name = TM2_TOUCHKEY_DEV_NAME; > touchkey->led_dev.brightness = LED_FULL; > - touchkey->led_dev.max_brightness = LED_FULL; > + touchkey->led_dev.max_brightness = LED_ON; > touchkey->led_dev.brightness_set = tm2_touchkey_led_brightness_set; > > error = devm_led_classdev_register(&client->dev, &touchkey->led_dev); > -- > 2.11.0 > -- Dmitry