From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751141AbdFBF6C (ORCPT ); Fri, 2 Jun 2017 01:58:02 -0400 Received: from mga14.intel.com ([192.55.52.115]:63206 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750747AbdFBF6B (ORCPT ); Fri, 2 Jun 2017 01:58:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,283,1493708400"; d="scan'208";a="109503323" Date: Thu, 1 Jun 2017 23:57:59 -0600 From: Ross Zwisler To: "Huang, Ying" Cc: Andrew Morton , Jens Axboe , Minchan Kim , Ross Zwisler , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Johannes Weiner , linux-nvdimm@ml01.01.org Subject: Re: [PATCH -mm 05/13] block, THP: Make block_device_operations.rw_page support THP Message-ID: <20170602055759.GC5909@linux.intel.com> References: <20170525064635.2832-1-ying.huang@intel.com> <20170525064635.2832-6-ying.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170525064635.2832-6-ying.huang@intel.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 25, 2017 at 02:46:27PM +0800, Huang, Ying wrote: > From: Huang Ying > > The .rw_page in struct block_device_operations is used by the swap > subsystem to read/write the page contents from/into the corresponding > swap slot in the swap device. To support the THP (Transparent Huge > Page) swap optimization, the .rw_page is enhanced to support to > read/write THP if possible. > > Signed-off-by: "Huang, Ying" > Cc: Johannes Weiner > Cc: Minchan Kim > Cc: Dan Williams > Cc: Ross Zwisler > Cc: Vishal L Verma > Cc: Jens Axboe > Cc: linux-nvdimm@lists.01.org > --- > drivers/block/brd.c | 6 +++++- > drivers/block/zram/zram_drv.c | 2 ++ > drivers/nvdimm/btt.c | 4 +++- > drivers/nvdimm/pmem.c | 42 +++++++++++++++++++++++++++++++----------- > 4 files changed, 41 insertions(+), 13 deletions(-) The changes in brd.c, zram_drv.c and pmem.c look good to me. For those bits you can add: Reviewed-by: Ross Zwisler I think we still want Vishal to make sure that the BTT changes are okay. I don't know that code well enough to know whether it's safe to throw 512 pages at btt_[read|write]_pg(). Also, Ying, next time can you please CC me (and probably the linux-nvdimm list) on the whole series? It would give us more context on what the larger change is, allow us to see the cover letter, allow us to test with all the patches in the series, etc. It's pretty easy for reviewers to skip over the patches we don't care about or aren't in our area. Thanks, - Ross