From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751294AbdFBJfu (ORCPT ); Fri, 2 Jun 2017 05:35:50 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:35167 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbdFBJfr (ORCPT ); Fri, 2 Jun 2017 05:35:47 -0400 Date: Fri, 2 Jun 2017 11:35:25 +0200 From: Boris Brezillon To: Jose Abreu Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Carlos Palminha , Daniel Vetter , David Airlie Subject: Re: [PATCH v5 09/10] drm/atmel-hlcdc: Use crtc->mode_valid() callback Message-ID: <20170602113525.484caa94@bbrezillon> In-Reply-To: <95fd6c06c58bd0b957e36a8d7068e6a74b581304.1495720737.git.joabreu@synopsys.com> References: <95fd6c06c58bd0b957e36a8d7068e6a74b581304.1495720737.git.joabreu@synopsys.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 May 2017 15:19:21 +0100 Jose Abreu wrote: > Now that we have a callback to check if crtc supports a given mode > we can use it in atmel-hlcdc so that we restrict the number of probbed > modes to the ones we can actually display. > > Also, remove the mode_fixup() callback as this is no longer needed > because mode_valid() will be called before. > > NOTE: Not even compiled tested Applied to drm-misc-next after fixing a compilation warning and reformating to checkpatch happy. Thanks, Boris > > Signed-off-by: Jose Abreu > Cc: Carlos Palminha > Cc: Daniel Vetter > Cc: Boris Brezillon > Cc: David Airlie > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > index 53bfa56..bdfe74e 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > @@ -140,13 +140,12 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c) > cfg); > } > > -static bool atmel_hlcdc_crtc_mode_fixup(struct drm_crtc *c, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > +static enum drm_mode_status atmel_hlcdc_crtc_mode_valid(struct drm_crtc *c, > + const struct drm_display_mode *mode) > { > struct atmel_hlcdc_crtc *crtc = drm_crtc_to_atmel_hlcdc_crtc(c); > > - return atmel_hlcdc_dc_mode_valid(crtc->dc, adjusted_mode) == MODE_OK; > + return atmel_hlcdc_dc_mode_valid(crtc->dc, mode); > } > > static void atmel_hlcdc_crtc_disable(struct drm_crtc *c) > @@ -315,7 +314,7 @@ static void atmel_hlcdc_crtc_atomic_flush(struct drm_crtc *crtc, > } > > static const struct drm_crtc_helper_funcs lcdc_crtc_helper_funcs = { > - .mode_fixup = atmel_hlcdc_crtc_mode_fixup, > + .mode_valid = atmel_hlcdc_crtc_mode_valid, > .mode_set = drm_helper_crtc_mode_set, > .mode_set_nofb = atmel_hlcdc_crtc_mode_set_nofb, > .mode_set_base = drm_helper_crtc_mode_set_base,