public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH 0/4] mfd: make da90xx drivers explicitly non-modular
Date: Sat, 3 Jun 2017 09:03:47 -0400	[thread overview]
Message-ID: <20170603130351.13913-1-paul.gortmaker@windriver.com> (raw)

At the risk of repeating the same boiler plate, in this cleanup we continue
to make driver code consistent with the Makefiles/Kconfigs that control them.

This means not using modular functions/macros for drivers that can never
be built as a module.  Some of the main downfalls this leads to are:

 (1) it is easy to accidentally write unused module_exit and remove code
 (2) it can be misleading when reading the source, thinking it can be
     modular when the Makefile and/or Kconfig prohibit it
 (3) it requires the include of the module.h header file which in turn
     includes nearly everything else, thus adding to CPP overhead.
 (4) it gets copied/replicated into other drivers and thus spreads.

As always, the option exists for someone with the hardware and the desire
to extend the functionality to make any given driver tristate.  But given
the number of these tree wide and the fact that I can't test that new
extended functionality in all cases, I just make the code consistent with
existing Kconfig/Makefile settings that currently restrict them to "bool".

Build tested on linux-next for arm, arm64 and x86-64 to ensure no typos
or similar issues crept in.  The diffstat summary speaks for itself.

Paul Gortmaker (4):
  mfd: da903x: Make it explicitly non-modular
  mfd: da9052-*: Make it explicitly non-modular
  mfd: da9055-core: make it explicitly non-modular
  mfd: da9055-i2c: Make it explicitly non-modular

 drivers/mfd/da903x.c              | 26 +++-----------------------
 drivers/mfd/da9052-core.c         | 11 -----------
 drivers/mfd/da9052-i2c.c          | 22 ++--------------------
 drivers/mfd/da9052-irq.c          |  1 -
 drivers/mfd/da9052-spi.c          | 22 ++--------------------
 drivers/mfd/da9055-core.c         | 13 ++-----------
 drivers/mfd/da9055-i2c.c          | 24 ++----------------------
 include/linux/mfd/da9052/da9052.h |  1 -
 8 files changed, 11 insertions(+), 109 deletions(-)

-- 
2.11.0

             reply	other threads:[~2017-06-03 13:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-03 13:03 Paul Gortmaker [this message]
2017-06-03 13:03 ` [PATCH 1/4] mfd: da903x: Make it explicitly non-modular Paul Gortmaker
2017-06-05 10:30   ` Steve Twiss
2017-06-05 19:29     ` Paul Gortmaker
2017-06-06 15:27       ` Steve Twiss
2017-06-06 20:22         ` Paul Gortmaker
2017-06-07 14:36           ` Steve Twiss
2017-06-05 10:36   ` Lee Jones
2017-06-06 14:22     ` Paul Gortmaker
2017-06-03 13:03 ` [PATCH 2/4] mfd: da9052-*: " Paul Gortmaker
2017-06-03 13:03 ` [PATCH 3/4] mfd: da9055-core: make " Paul Gortmaker
2017-06-04  5:51   ` kbuild test robot
2017-06-06 14:26     ` Paul Gortmaker
2017-06-04  5:54   ` kbuild test robot
2017-06-03 13:03 ` [PATCH 4/4] mfd: da9055-i2c: Make " Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170603130351.13913-1-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox