From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751748AbdFEKjz (ORCPT ); Mon, 5 Jun 2017 06:39:55 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:48877 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751404AbdFEKjy (ORCPT ); Mon, 5 Jun 2017 06:39:54 -0400 Date: Mon, 5 Jun 2017 03:39:47 -0700 From: Christoph Hellwig To: Chao Yu Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, chao@kernel.org Subject: Re: [PATCH 4/4] f2fs: use bio_set_op_attrs Message-ID: <20170605103947.GA21376@infradead.org> References: <20170605102909.57625-1-yuchao0@huawei.com> <20170605102909.57625-4-yuchao0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170605102909.57625-4-yuchao0@huawei.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 05, 2017 at 06:29:09PM +0800, Chao Yu wrote: > Init bio->bi_opf with bio_set_op_attrs instead of opened code. > > Signed-off-by: Chao Yu > --- > fs/f2fs/data.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index 2ed90f5db832..204150cf6561 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -1962,7 +1962,7 @@ static int f2fs_write_begin(struct file *file, struct address_space *mapping, > err = PTR_ERR(bio); > goto fail; > } > - bio->bi_opf = REQ_OP_READ; > + bio_set_op_attrs(bio, REQ_OP_READ, 0); NAK. Please read the comment next to bio_set_op_attrs.