From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751289AbdFEOzL (ORCPT ); Mon, 5 Jun 2017 10:55:11 -0400 Received: from verein.lst.de ([213.95.11.211]:40468 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbdFEOzK (ORCPT ); Mon, 5 Jun 2017 10:55:10 -0400 Date: Mon, 5 Jun 2017 16:55:08 +0200 From: Christoph Hellwig To: Andy Shevchenko Cc: Stephen Rothwell , Christoph Hellwig , Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: new tree for linux-next: uuid Message-ID: <20170605145508.GA28858@lst.de> References: <20170604201413.GA12748@lst.de> <20170605094956.069d5af3@canb.auug.org.au> <20170605080713.GA22028@lst.de> <1496671605.22624.2.camel@linux.intel.com> <20170606002914.695e9c0b@canb.auug.org.au> <1496673798.22624.9.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1496673798.22624.9.camel@linux.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 05, 2017 at 05:43:18PM +0300, Andy Shevchenko wrote: > On Tue, 2017-06-06 at 00:29 +1000, Stephen Rothwell wrote: > > Hi Andy, > > > > On Mon, 05 Jun 2017 17:06:45 +0300 Andy Shevchenko > linux.intel.com> wrote: > > > > > > On Mon, 2017-06-05 at 10:07 +0200, Christoph Hellwig wrote: > > > > Meh, thanks.  This has been throught the buildbot countless times > > > > without a report.  But I guess a less generic name might be a good > > > > idea to start with. > > > > > > > > Andy: do you think UUID_INIT/GUID_INIT make sense to your? > > > > or _INITIALIZER?   > > > > > > I'm a bit out of context. Where this will be used? > > > > include/uapi/linux/uuid.h (after the uuid lib changes) contains a > > definition of the macro GUID() which is probably a bit generic a name > > for a uapi include file.  It also clashes with a couple of other uses > > of that macro name already in the kernel (one of which produced > > several > > warnings in linux-next today). > > > > It produces an initializer for a guid_t (structure). > > Just had read and finished answering to a warning. > In kernel users shouldn't really use so generic names, we may fix it. > > OTOH, for user space I dunno if need to export that at all. > If we need by some reason, shorter version looks better, GUID_INIT(), > UUID_INIT()... I'll fix it up without resending the whole series. I'll also apply your ACPI changes and if there is no major fallout we can declare the branch stable for drm in a few days.