From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751327AbdFEQBF (ORCPT ); Mon, 5 Jun 2017 12:01:05 -0400 Received: from verein.lst.de ([213.95.11.211]:40756 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751238AbdFEQBE (ORCPT ); Mon, 5 Jun 2017 12:01:04 -0400 Date: Mon, 5 Jun 2017 18:01:02 +0200 From: Christoph Hellwig To: Andy Shevchenko Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, "Rafael J . Wysocki " , linux-acpi@vger.kernel.org, Dan Williams , Mika Westerberg , Borislav Petkov , intel-gfx@lists.freedesktop.org Subject: Re: [PATCH v2 1/5] acpi, nfit: Switch to use new generic UUID API Message-ID: <20170605160102.GA29981@lst.de> References: <20170531194152.65927-1-andriy.shevchenko@linux.intel.com> <20170531194152.65927-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170531194152.65927-2-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > for (i = 0; i < NFIT_UUID_MAX; i++) > - if (memcmp(to_nfit_uuid(i), spa->range_guid, 16) == 0) > + if (!guid_equal(to_nfit_uuid(i), (guid_t *)&spa->range_guid)) > return i; I think this should be guid_equal without the "!"