From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751321AbdFEUuI (ORCPT ); Mon, 5 Jun 2017 16:50:08 -0400 Received: from gateway31.websitewelcome.com ([192.185.143.4]:11562 "EHLO gateway31.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751189AbdFEUuH (ORCPT ); Mon, 5 Jun 2017 16:50:07 -0400 Date: Mon, 5 Jun 2017 15:50:02 -0500 From: "Gustavo A. R. Silva" To: Jiri Kosina , David Sterba , Greg Kroah-Hartman , Jiri Slaby Cc: linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] tty: ipwireless: fix potential NULL pointer dereference Message-ID: <20170605205002.GA4896@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.175.0.156 X-Exim-ID: 1dHywt-000GUT-MP X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.175.0.156]:54378 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 5 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add null check before dereferencing pointer ver_packet. Print error message and exit in case pointer ver_packet is NULL. Addresses-Coverity-ID: 1362295 Signed-off-by: Gustavo A. R. Silva --- drivers/tty/ipwireless/hardware.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/tty/ipwireless/hardware.c b/drivers/tty/ipwireless/hardware.c index df0204b..20db99d 100644 --- a/drivers/tty/ipwireless/hardware.c +++ b/drivers/tty/ipwireless/hardware.c @@ -1515,6 +1515,13 @@ static void ipw_send_setup_packet(struct ipw_hardware *hw) sizeof(struct ipw_setup_get_version_query_packet), ADDR_SETUP_PROT, TL_PROTOCOLID_SETUP, TL_SETUP_SIGNO_GET_VERSION_QRY); + + if (!ver_packet) { + pr_err(IPWIRELESS_PCCARD_NAME + ": Not enough memory to send packet\n"); + return; + } + ver_packet->header.length = sizeof(struct tl_setup_get_version_qry); /* -- 2.5.0