From: David Sterba <dsterba@suse.cz>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <JSlaby@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: ipwireless: fix potential NULL pointer dereference
Date: Tue, 6 Jun 2017 12:39:40 +0200 [thread overview]
Message-ID: <20170606103940.GY12135@suse.cz> (raw)
In-Reply-To: <20170605205002.GA4896@embeddedgus>
On Mon, Jun 05, 2017 at 03:50:02PM -0500, Gustavo A. R. Silva wrote:
> Add null check before dereferencing pointer ver_packet.
> Print error message and exit in case pointer ver_packet
> is NULL.
And what next? The caller does not expect a failure and continues as if
the packet has been set up and sent and waiting for a response. This
will likely hang somewhere or just do nothing regarding
sending/receiving user packets. Failures of alloc_ctrl_packet are
handled elsewhere, even during the setup phase so this could be handled
more gracefully.
prev parent reply other threads:[~2017-06-06 10:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 20:50 [PATCH] tty: ipwireless: fix potential NULL pointer dereference Gustavo A. R. Silva
2017-06-06 10:39 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606103940.GY12135@suse.cz \
--to=dsterba@suse.cz \
--cc=JSlaby@suse.com \
--cc=garsilva@embeddedor.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox