From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751464AbdFFPUI (ORCPT ); Tue, 6 Jun 2017 11:20:08 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:44980 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbdFFPUG (ORCPT ); Tue, 6 Jun 2017 11:20:06 -0400 Date: Tue, 6 Jun 2017 08:20:01 -0700 From: "Paul E. McKenney" To: kbuild test robot Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org Subject: Re: [rcu:rcu/next 64/99] kernel/rcu/srcu.c:517:15: error: redefinition of 'srcu_batches_completed' Reply-To: paulmck@linux.vnet.ibm.com References: <201706060622.PV8kG3jN%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201706060622.PV8kG3jN%fengguang.wu@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17060615-0008-0000-0000-00000237E315 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007183; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000212; SDB=6.00870989; UDB=6.00433157; IPR=6.00650982; BA=6.00005402; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015720; XFM=3.00000015; UTC=2017-06-06 15:20:03 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17060615-0009-0000-0000-0000358ECC56 Message-Id: <20170606152001.GA30091@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-06_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706060261 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 06, 2017 at 06:22:32AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next > head: 5c246613fb794485c9af0c20dff8218abfc848aa > commit: dec7813dfa40f7a48b0f3d9e48fe7bcf0b1b622d [64/99] srcu: Shrink srcu.h by moving docbook and private function > config: x86_64-randconfig-x006-201723 (attached as .config) > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > reproduce: > git checkout dec7813dfa40f7a48b0f3d9e48fe7bcf0b1b622d > # save the attached .config to linux build tree > make ARCH=x86_64 > > Note: the rcu/rcu/next HEAD 5c246613fb794485c9af0c20dff8218abfc848aa builds fine. > It only hurts bisectibility. Good catch! However, given that you have to have !SMP&&CLASSIC_SRCU to hit this, and given that CLASSIC_SRCU goes away in this series, you would have to work to have a bisection problem in this range. In theory, I could move commit 0ce2e8a0aa44 ("srcu: Remove Classic SRCU") before commit dec7813dfa40 ("srcu: Shrink srcu.h by moving docbook and private function"), but in practice, this would introduce more risk than leaving the bisection window open. So I will leave this one alone. Thanx, Paul > All errors (new ones prefixed by >>): > > >> kernel/rcu/srcu.c:517:15: error: redefinition of 'srcu_batches_completed' > unsigned long srcu_batches_completed(struct srcu_struct *sp) > ^~~~~~~~~~~~~~~~~~~~~~ > In file included from kernel/rcu/srcu.c:39:0: > kernel/rcu/rcu.h:495:29: note: previous definition of 'srcu_batches_completed' was here > static inline unsigned long srcu_batches_completed(struct srcu_struct *sp) > ^~~~~~~~~~~~~~~~~~~~~~ > > vim +/srcu_batches_completed +517 kernel/rcu/srcu.c > > 621934ee kernel/srcu.c Paul E. McKenney 2006-10-04 511 * srcu_batches_completed - return batches completed. > 621934ee kernel/srcu.c Paul E. McKenney 2006-10-04 512 * @sp: srcu_struct on which to report batch completion. > 621934ee kernel/srcu.c Paul E. McKenney 2006-10-04 513 * > 621934ee kernel/srcu.c Paul E. McKenney 2006-10-04 514 * Report the number of batches, correlated with, but not necessarily > 621934ee kernel/srcu.c Paul E. McKenney 2006-10-04 515 * precisely the same as, the number of grace periods that have elapsed. > 621934ee kernel/srcu.c Paul E. McKenney 2006-10-04 516 */ > a5c198f4 kernel/rcu/srcu.c Paul E. McKenney 2014-11-23 @517 unsigned long srcu_batches_completed(struct srcu_struct *sp) > 621934ee kernel/srcu.c Paul E. McKenney 2006-10-04 518 { > 621934ee kernel/srcu.c Paul E. McKenney 2006-10-04 519 return sp->completed; > 621934ee kernel/srcu.c Paul E. McKenney 2006-10-04 520 } > > :::::: The code at line 517 was first introduced by commit > :::::: a5c198f4f7da6cc48116ca239c59c9f44b753364 rcu: Expand SRCU ->completed to 64 bits > > :::::: TO: Paul E. McKenney > :::::: CC: Paul E. McKenney > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation