public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Kershner, David A" <David.Kershner@unisys.com>
Cc: *S-Par-Maintainer <SParMaintainer@unisys.com>,
	"driverdev-devel@linuxdriverproject.org" 
	<driverdev-devel@linuxdriverproject.org>,
	"jes.sorensen@gmail.com" <jes.sorensen@gmail.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@kernel.org" <mingo@kernel.org>
Subject: Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus
Date: Tue, 6 Jun 2017 20:58:44 +0200	[thread overview]
Message-ID: <20170606185844.GA32155@kroah.com> (raw)
In-Reply-To: <CY4PR07MB3176DDC0432936E51A865B38F0CB0@CY4PR07MB3176.namprd07.prod.outlook.com>

On Tue, Jun 06, 2017 at 06:20:17PM +0000, Kershner, David A wrote:
> 
> 
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > Sent: Tuesday, June 6, 2017 11:06 AM
> > To: Kershner, David A <David.Kershner@unisys.com>
> > Cc: corbet@lwn.net; tglx@linutronix.de; mingo@kernel.org; akpm@linux-
> > foundation.org; jes.sorensen@gmail.com; linux-kernel@vger.kernel.org;
> > linux-doc@vger.kernel.org; driverdev-devel@linuxdriverproject.org; *S-Par-
> > Maintainer <SParMaintainer@unisys.com>
> > Subject: Re: [PATCH 0/3] move visorbus out of staging to
> > drivers/virt/visorbus
> > 
> > On Tue, Jun 06, 2017 at 04:54:30PM +0200, Greg KH wrote:
> > > On Tue, Jun 06, 2017 at 04:53:22PM +0200, Greg KH wrote:
> > > > On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote:
> > > > > On Mon, Jun 05, 2017 at 04:07:29PM -0400, David Kershner wrote:
> > > > > > This patchset moves drivers/staging/unisys/include to
> > > > > > include/linux/visorbus, and moves drivers/staging/unisys/visorbus to
> > > > > > drivers/virt/visorbus.
> > > > >
> > > > > Um, are you thinking it is ready to be moved?  Have you asked for
> > > > > another review?
> > > > >
> 
> Thank you for taking a quick look at our patch series. Part of the motivation
> behind this submission was, in fact, to initiate another code review. What is
> the formal procedure for initiating a code review?

Send an email that says, "Hey Greg, we think the code is ready to be
moved out of staging, can you review it to see if we have missed
anything?"

Of course, do it _AFTER_ you have fixed up the checkpatch.pl issues.
That's not even done yet...

thanks,

greg k-h

  reply	other threads:[~2017-06-06 18:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05 20:07 [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus David Kershner
2017-06-05 20:07 ` [PATCH 1/3] include: linux: visorbus: Add visorbus to include/linux directory David Kershner
2017-06-07 13:58   ` Christoph Hellwig
2017-06-05 20:07 ` [PATCH 2/3] Documentation: Move visorbus documentation from staging to Documentation/ David Kershner
2017-06-06  8:02   ` Jani Nikula
2017-06-05 20:07 ` [PATCH 3/3] drivers: virt: Add visorbus to the drivers/virt directory David Kershner
2017-06-06 21:47   ` kbuild test robot
2017-06-06 14:49 ` [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus Greg KH
2017-06-06 14:53   ` Greg KH
2017-06-06 14:54     ` Greg KH
2017-06-06 15:06       ` Greg KH
2017-06-06 18:20         ` Kershner, David A
2017-06-06 18:58           ` Greg KH [this message]
2017-06-06 15:33     ` Joe Perches
2017-06-06 15:39       ` Greg KH
2017-06-06 15:52         ` Joe Perches
2017-06-06 16:01           ` Greg KH
2017-06-07 13:59   ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2016-06-11  3:23 David Kershner
2016-06-14 13:30 ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170606185844.GA32155@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=David.Kershner@unisys.com \
    --cc=SParMaintainer@unisys.com \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=jes.sorensen@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox