From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Russ Anderson <rja@hpe.com>,
Dimitri Sivanich <sivanich@hpe.com>,
"travis@sgi.com" <travis@sgi.com>,
Mike Travis <mike.travis@hpe.com>,
Frank Ramsay <frank.ramsay@hpe.com>,
Thomas Garnier <thgarnie@google.com>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [PATCH v2 0/2] x86/mm/KASLR: Do not adapt size of the direct mapping section for SGI UV system
Date: Wed, 7 Jun 2017 12:35:33 +0800 [thread overview]
Message-ID: <20170607043533.GA6341@x1> (raw)
In-Reply-To: <1495281758-11320-1-git-send-email-bhe@redhat.com>
Hi all,
PING!
Is there any further comment or suggetion about this patchset?
Thanks
Baoquan
On 05/20/17 at 08:02pm, Baoquan He wrote:
> This is v2 post.
>
> This patchset is trying to fix a bug that SGI UV system casually hang
> during boot with KASLR enabled. The root cause is that mm KASLR adapts
> size of the direct mapping section only based on the system RAM size.
> Then later when map SGI UV MMIOH region into the direct mapping during
> rest_init() invocation, it might go beyond of the directing mapping
> section and step into VMALLOC or VMEMMAP area, then BUG_ON triggered.
>
> The fix is adding a helper function is_early_uv_system to check UV system
> earlier, then call the helper function in kernel_randomize_memory() to
> check if it's a SGI UV system, if yes, we keep the size of direct mapping
> section to be 64TB just as nokslr.
>
> With this fix, SGI UV system can have 64TB direct mapping size always,
> and the starting address of direct mapping/vmalloc/vmemmap and the padding
> between them can still be randomized to enhance the system security.
>
> v1->v2:
> 1. Mike suggested making is_early_uv_system() an inline function and be
> put in include/asm/uv/uv.h so that they can adjust them easier in the
> future.
>
> 2. Split the v1 code into uv part and mm KASLR part as Mike suggested.
>
> Baoquan He (2):
> x86/UV: Introduce a helper function to check UV system at earlier
> stage
> x86/mm/KASLR: Do not adapt the size of the direct mapping section for
> SGI UV system
>
> arch/x86/include/asm/uv/uv.h | 6 ++++++
> arch/x86/mm/kaslr.c | 3 ++-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> --
> 2.5.5
>
prev parent reply other threads:[~2017-06-07 4:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-20 12:02 [PATCH v2 0/2] x86/mm/KASLR: Do not adapt size of the direct mapping section for SGI UV system Baoquan He
2017-05-20 12:02 ` [PATCH v2 1/2] x86/UV: Introduce a helper function to check UV system at earlier stage Baoquan He
2017-05-23 15:17 ` Mike Travis
2017-05-20 12:02 ` [PATCH v2 2/2] x86/mm/KASLR: Do not adapt size of the direct mapping section for SGI UV system Baoquan He
2017-05-21 20:38 ` Thomas Garnier
2017-05-21 23:14 ` Baoquan He
2017-05-21 23:17 ` Baoquan He
[not found] ` <19a8e832-49db-cb68-bbfd-a5ba1cb8be1e@hpe.com>
2017-05-22 17:00 ` Thomas Garnier
2017-08-31 6:21 ` Baoquan He
2017-06-07 4:35 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607043533.GA6341@x1 \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=frank.ramsay@hpe.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.travis@hpe.com \
--cc=mingo@redhat.com \
--cc=rja@hpe.com \
--cc=sivanich@hpe.com \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=travis@sgi.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).