From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751754AbdFGHDF (ORCPT ); Wed, 7 Jun 2017 03:03:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40896 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751704AbdFGHDD (ORCPT ); Wed, 7 Jun 2017 03:03:03 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A99FDC0587D5 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=benjamin.tissoires@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A99FDC0587D5 Date: Wed, 7 Jun 2017 09:02:55 +0200 From: Benjamin Tissoires To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Andrew Duggan , Lyude Paul , Damjan Georgievski , Masaki Ota , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: synaptics_rmi4 - register F03 port as pass-through serio Message-ID: <20170607070255.GA16591@mail.corp.redhat.com> References: <20170607065128.GA31686@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170607065128.GA31686@dtor-ws> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 07 Jun 2017 07:03:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jun 06 2017 or thereabouts, Dmitry Torokhov wrote: > The 5th generation Thinkpad X1 Carbons use Synaptics touchpads accessible > over SMBus/RMI, combined with ALPS or Elantech trackpoint devices instead > of classic IBM/Lenovo trackpoints. Unfortunately there is no way for ALPS > driver to detect whether it is dealing with touchpad + trackpoint > combination or just a trackpoint, so we end up with a "phantom" dualpoint > ALPS device in addition to real touchpad and trackpoint. > > Given that we do not have any special advanced handling for ALPS or > Elantech trackpoints (unlike IBM trackpoints that have separate driver and > a host of options) we are better off keeping the trackpoints in PS/2 > emulation mode. We achieve that by setting serio type to SERIO_PS_PSTHRU, > which will limit number of protocols psmouse driver will try. In addition > to getting rid of the "phantom" touchpads, this will also speed up probing > of F03 pass-through port. > > Reported-by: Damjan Georgievski > Suggested-by: Benjamin Tissoires > Signed-off-by: Dmitry Torokhov > --- Thanks for the extensive commit message :) Acked-by: Benjamin Tissoires (tested on a t450s without problems). Cheers, Benjamin > drivers/input/rmi4/rmi_f03.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/rmi4/rmi_f03.c b/drivers/input/rmi4/rmi_f03.c > index 77dad045a468..ad71a5e768dc 100644 > --- a/drivers/input/rmi4/rmi_f03.c > +++ b/drivers/input/rmi4/rmi_f03.c > @@ -146,7 +146,7 @@ static int rmi_f03_register_pt(struct f03_data *f03) > if (!serio) > return -ENOMEM; > > - serio->id.type = SERIO_8042; > + serio->id.type = SERIO_PS_PSTHRU; > serio->write = rmi_f03_pt_write; > serio->port_data = f03; > > -- > 2.13.0.506.g27d5fe0cd-goog > > > -- > Dmitry